Skip to content

Test environment requires compilers #1348

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 16, 2023
Merged

Test environment requires compilers #1348

merged 3 commits into from
Aug 16, 2023

Conversation

oleksandr-pavlyk
Copy link
Contributor

This PR adds compilers to test requirements list.

test_sycl_queue.py::test_cython_api requires a compiler to build a native extension.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you opening the PR as a draft?

@oleksandr-pavlyk
Test environment requires compilers
0ed60a9 
test_sycl_queue.py::test_cython_api requires a compiler to build
a native extension.
@github-actions
Copy link

View rendered docs @ https://intelpython.github.io/dpctl/pulls/1348/index.html

@coveralls
Copy link
Collaborator

coveralls commented Aug 16, 2023 •
edited
Loading

Coverage Status

coverage: 84.95%. remained the same when pulling 7f7897c on test-requires-compilers into 9afdb58 on master.

@github-actions
Copy link

Array API standard conformance tests for dpctl=0.14.6dev3=py310ha25a700_6 ran successfully.
Passed: 913
Failed: 87
Skipped: 119

@oleksandr-pavlyk
Adding test to prevent gh-1344 from reoccuring
2256fb3 
Adds a simple C extension, compiled with C compiler that includes
dpctl_capi header file. This mimics use dpctl_capi from numba_dpex.
@oleksandr-pavlyk
Updated copyright year range
7f7897c
@github-actions
Copy link

Array API standard conformance tests for dpctl=0.14.6dev3=py310ha25a700_8 ran successfully.
Passed: 913
Failed: 87
Skipped: 119

@oleksandr-pavlyk
Copy link
Contributor Author

@diptorupd I have also added a test to compile C-based native extension that includes "dpctl_capi.h" header file to ensure that issues spotted in gh-1344 wont regress.

@ekomarova
Copy link
Contributor

Tests for windows are still in the queue and are not displayed in checks

@oleksandr-pavlyk
Copy link
Contributor Author

Tests on Windows passed in the internal CI for at least on Python version (3.10). For another (3.9) the failure is unrelated to this change.

ekomarova
ekomarova approved these changes Aug 16, 2023
View reviewed changes
Copy link
Contributor

@ekomarova ekomarova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@oleksandr-pavlyk oleksandr-pavlyk merged commit 47c82f5 into master Aug 16, 2023
@oleksandr-pavlyk oleksandr-pavlyk deleted the test-requires-compilers branch August 16, 2023 19:08
@github-actions
Copy link

Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞

@github-actions
Copy link

Array API standard conformance tests for dpctl=0.14.6dev3=py310ha25a700_10 ran successfully.
Passed: 913
Failed: 87
Skipped: 119

@oleksandr-pavlyk oleksandr-pavlyk mentioned this pull request Aug 18, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ekomarova ekomarova ekomarova approved these changes

@diptorupd diptorupd Awaiting requested review from diptorupd

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@oleksandr-pavlyk @coveralls @ekomarova