Skip to content

Closes gh-1344 #1345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 15, 2023
Merged

Closes gh-1344 #1345

merged 1 commit into from
Aug 15, 2023

Conversation

oleksandr-pavlyk
Copy link
Contributor

Define CYTHON_EXTERN_C as empty for C compilers.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you opening the PR as a draft?

Define CYTHON_EXTERN_C as empty for C compilers.
@github-actions
Copy link

@coveralls
Copy link
Collaborator

Coverage Status

coverage: 84.95%. remained the same when pulling da63be5 on fix-gh-1344 into 50f1074 on master.

@github-actions
Copy link

Array API standard conformance tests for dpctl=0.14.6dev2=py310h7bf5fec_4 ran successfully.
Passed: 913
Failed: 87
Skipped: 119

@oleksandr-pavlyk
Copy link
Contributor Author

Verified that this change fixes build of numba-dpex. Hence merging. A test to try to build native C extension that includes the "dpctl_capi" header file will be added in a separate PR.

@oleksandr-pavlyk oleksandr-pavlyk merged commit 6070755 into master Aug 15, 2023
@oleksandr-pavlyk oleksandr-pavlyk deleted the fix-gh-1344 branch August 15, 2023 18:54
@github-actions
Copy link

Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞

@github-actions
Copy link

Array API standard conformance tests for dpctl=0.14.6dev2=py310h7bf5fec_4 ran successfully.
Passed: 913
Failed: 87
Skipped: 119

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants