Shift tuple support when axis=None for dpctl.tensor.roll #1341
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR suggests adding support for the case when
shift is tuple
andaxis=None
fordpctl.tensor.roll
.The previous implementation raised
TypeError
exception causecopy_usm_ndarray_for_reshape
expects shift as an integer.Additionally, the PR adds a check for the equality of the
source
anddestination
parameters to return the input arrayX
without having to move its axes indpctl.tensor.moveaxis
.