Enable support for Python operators in usm_ndarray class #1324

oleksandr-pavlyk · 2023-08-02T21:46:56Z

This PR has the effect of unlocking use of dpctl.tensor elementwise functions to power special methods in usm_ndarray class.

In [1]: import dpctl.tensor as dpt, numpy as np

In [2]: dpt.ones(10) / 2
Out[2]: usm_ndarray([0.5, 0.5, 0.5, 0.5, 0.5, 0.5, 0.5, 0.5, 0.5, 0.5], dtype=float32)

Have you provided a meaningful PR description?
Have you added a test, reproducer or referred to an issue with a reproducer?
Have you tested your changes locally for CPU and GPU devices?
Have you made sure that new changes do not introduce compiler warnings?
Have you checked performance impact of proposed changes?
If this PR is a work in progress, are you opening the PR as a draft?

github-actions · 2023-08-02T22:20:23Z

View rendered docs @ https://intelpython.github.io/dpctl/pulls/1324/index.html

usm_ndarray constructor's array_namespace argument's default value of None is now interpreted to mean that usm_ndarray.__array_namespace__ returns dpctl.tensor, rather than None. This directly affects how Python operator special methods of usm_ndarray behave. They would now look up corresponding attribute in dpctl.tensor namespace.

coveralls · 2023-08-03T01:25:41Z

coverage: 84.919% (+0.08%) from 84.839% when pulling ebd1faf on enable-operators into acd1a60 on master.

github-actions · 2023-08-03T02:50:05Z

Array API standard conformance tests for dpctl=0.14.6dev0=py310h7bf5fec_89 ran successfully.
Passed: 796
Failed: 204
Skipped: 119

``` In [1]: dpctl.tensor._usmarray as ua ua._basic_slice_meta((0, slice(1, 0, None)), (4, 4), (4, 1), 0) ``` The issue was discovered by array API conformance tests.

github-actions · 2023-08-03T16:17:22Z

Array API standard conformance tests for dpctl=0.14.6dev0=py310h7bf5fec_90 ran successfully.
Passed: 796
Failed: 204
Skipped: 119

``` import dpctl.tensor as dpt x = dpt.empy((0,2), dtype='i4') x[Ellipsis, 1] returns empty 1d array ```

- "power" corrected to "pow, "mod" corrected to "remainder" - logical functions corrected to bitwise

github-actions · 2023-08-03T18:23:24Z

Array API standard conformance tests for dpctl=0.14.6dev0=py310h7bf5fec_91 ran successfully.
Passed: 799
Failed: 201
Skipped: 119

github-actions · 2023-08-03T19:15:28Z

Array API standard conformance tests for dpctl=0.14.6dev0=py310h7bf5fec_95 ran successfully.
Passed: 905
Failed: 95
Skipped: 119

``` import dpctl.tensor as dpt import dpctl.tensor._usmarray as ua x = dpt.asarray([[0, 0], [1, 0]], dtype='int8') key = (None, 0, slice(1, None, -1)) meta = ua._basic_slice_meta(key, x.shape, x.strides, x._element_offset) y = dpt.usm_ndarray.__new__(dpt.usm_ndarray, meta[0], dtype=x.dtype, strides=meta[1], buffer=x.usm_data, offset=meta[2]) print(y.flags) ``` Both 'C' and 'F' flags of the created array used to be set, now both are correctly unset.

- Incorrect test logic was being hidden by the bug

github-actions · 2023-08-03T22:42:23Z

Array API standard conformance tests for dpctl=0.14.6dev0=py310h7bf5fec_97 ran successfully.
Passed: 891
Failed: 109
Skipped: 119

github-actions · 2023-08-06T06:11:52Z

Array API standard conformance tests for dpctl=0.14.6dev0=py310h7bf5fec_100 ran successfully.
Passed: 894
Failed: 106
Skipped: 119

Array API tests pointed out an error in implementation of order='K' in dpctl.tensor.astype. Moved _empty_like_orderK and fried from _type_utils to _copy_utils and used it to implement astype. Modified import statement in _elementwise_common where _empty_like* are used.

github-actions · 2023-08-06T21:37:13Z

Array API standard conformance tests for dpctl=0.14.6dev0=py310h7bf5fec_102 ran successfully.
Passed: 907
Failed: 93
Skipped: 119

github-actions · 2023-08-06T22:14:16Z

Array API standard conformance tests for dpctl=0.14.6dev0=py310h7bf5fec_102 ran successfully.
Passed: 907
Failed: 93
Skipped: 119

The dpctl/tests/test_type_utils.py has been removed.

``` import dpctl.tensor as dpt x1 = dpt.full(tuple(), 77, dtype='u2') x2 = dpt.zeros(2, dtype='uint8')[dpt.newaxis, :] dpt.concat((x1, x2), axis=None) ``` The reason the exception was raised is that _copy_usm_ndarray_for_reshape which is used in the implementation of concat with axis=None requires both source and destination to have the same data-type.

github-actions · 2023-08-07T01:53:09Z

Array API standard conformance tests for dpctl=0.14.6dev0=py310h7bf5fec_106 ran successfully.
Passed: 909
Failed: 91
Skipped: 119

If both arguments are -inf, the result is also -inf.

The change is to suppress RuntimeWarning arising from within assert_allclose utility.

…inished

Use `self.flags_` directly, instead of getting it via temporary Flags object.

dpctl/tensor/libtensor/include/kernels/elementwise_functions/logaddexp.hpp

github-actions · 2023-08-08T13:21:58Z

Array API standard conformance tests for dpctl=0.14.6dev0=py310h7bf5fec_118 ran successfully.
Passed: 912
Failed: 88
Skipped: 119

dpctl/tensor/libtensor/include/kernels/elementwise_functions/logaddexp.hpp

github-actions · 2023-08-08T17:28:38Z

Array API standard conformance tests for dpctl=0.14.6dev0=py310h7bf5fec_119 ran successfully.
Passed: 913
Failed: 87
Skipped: 119

github-actions · 2023-08-08T18:05:46Z

Array API standard conformance tests for dpctl=0.14.6dev0=py310h7bf5fec_120 ran successfully.
Passed: 913
Failed: 87
Skipped: 119

github-actions · 2023-08-08T19:06:45Z

Array API standard conformance tests for dpctl=0.14.6dev0=py310h7bf5fec_120 ran successfully.
Passed: 913
Failed: 87
Skipped: 119

oleksandr-pavlyk · 2023-08-09T03:05:01Z

Given that this PR has grown big, I am inclined to get it merged while deferring further changes to new PRs.

Would like a feedback from dpnp team about any disruption to dpnp test suite.

antonwolfy · 2023-08-09T13:25:22Z

Given that this PR has grown big, I am inclined to get it merged while deferring further changes to new PRs.

Would like a feedback from dpnp team about any disruption to dpnp test suite.

All dpnp tests are successfully passed with the PR.

ndgrigorian

If you won't be adding more changes and dpnp has no issues, then this PR LGTM @oleksandr-pavlyk .

github-actions · 2023-08-09T20:23:55Z

Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞

github-actions · 2023-08-09T21:51:14Z

Array API standard conformance tests for dpctl=0.14.6dev1=py310h7bf5fec_29 ran successfully.
Passed: 913
Failed: 87
Skipped: 119

oleksandr-pavlyk added 4 commits August 2, 2023 18:20

Corrected text of exception message

4555bf1

Corrected operator true_divide with divide

964db08

Fixed test per change in dpctl implementation

78aa99b

oleksandr-pavlyk force-pushed the enable-operators branch from 75cd2da to 78aa99b Compare August 3, 2023 00:48

Fixed _slice_len for vacuous slices

51bf9e1

``` In [1]: dpctl.tensor._usmarray as ua ua._basic_slice_meta((0, slice(1, 0, None)), (4, 4), (4, 1), 0) ``` The issue was discovered by array API conformance tests.

oleksandr-pavlyk and others added 2 commits August 3, 2023 11:56

Fixed issue discovered by array API tests

f4a31bb

``` import dpctl.tensor as dpt x = dpt.empy((0,2), dtype='i4') x[Ellipsis, 1] returns empty 1d array ```

Corrected remaining operators in _usmarray.pyx

05aa952

- "power" corrected to "pow, "mod" corrected to "remainder" - logical functions corrected to bitwise

oleksandr-pavlyk and others added 2 commits August 3, 2023 14:55

Fixed flags test case for changes to contiguity flag computation

22c95b6

- Incorrect test logic was being hidden by the bug

oleksandr-pavlyk added 3 commits August 4, 2023 07:58

unpacked chained method calls

4803f13

Fixed Cython warning

cc08b5d

Fixed array API test failure by adding validation

5c1a961

oleksandr-pavlyk added 3 commits August 6, 2023 08:13

Use bitwise_invert for __invert__

07faf2b

Merge remote-tracking branch 'origin/master' into enable-operators

440872d

oleksandr-pavlyk force-pushed the enable-operators branch from fd54583 to 3ddf51c Compare August 6, 2023 21:00

oleksandr-pavlyk added 2 commits August 6, 2023 20:12

Moved 2 tests from test_type_utils to elementwise/test_type_utils

51e3f15

The dpctl/tests/test_type_utils.py has been removed.

oleksandr-pavlyk added 6 commits August 7, 2023 11:42

Modularized logic implementing logaddexp

3c0aeed

If both arguments are -inf, the result is also -inf.

Change to test_complex_special_cases

cf7d9bf

The change is to suppress RuntimeWarning arising from within assert_allclose utility.

Array-API conformance testing can start as soon as build_linux jobs f…

8343edc

…inished

Fixed log-add-exp per review feedback

ebd1faf

Merge pull request #1328 from IntelPython/fix-some-array-api-test-cases

df8eb5f

Simplified flags_ computation in to_device method

7c94a33

Use `self.flags_` directly, instead of getting it via temporary Flags object.

oleksandr-pavlyk marked this pull request as ready for review August 8, 2023 10:14

oleksandr-pavlyk requested review from antonwolfy and ndgrigorian August 8, 2023 10:14

antonwolfy reviewed Aug 8, 2023

View reviewed changes

oleksandr-pavlyk force-pushed the enable-operators branch from 739475d to 9a34d76 Compare August 8, 2023 16:15

antonwolfy reviewed Aug 8, 2023

View reviewed changes

dpctl/tensor/libtensor/include/kernels/elementwise_functions/logaddexp.hpp Show resolved Hide resolved

dpctl/tensor/libtensor/include/kernels/elementwise_functions/logaddexp.hpp Outdated Show resolved Hide resolved

oleksandr-pavlyk force-pushed the enable-operators branch from 9a34d76 to 15fa52c Compare August 8, 2023 16:45

antonwolfy reviewed Aug 8, 2023

View reviewed changes

dpctl/tensor/libtensor/include/kernels/elementwise_functions/logaddexp.hpp Outdated Show resolved Hide resolved

oleksandr-pavlyk force-pushed the enable-operators branch from 15fa52c to ebd1faf Compare August 8, 2023 17:50

oleksandr-pavlyk mentioned this pull request Aug 9, 2023

Incorrect behavior of order parameter for order="K" #1326

Closed

ndgrigorian approved these changes Aug 9, 2023

View reviewed changes

oleksandr-pavlyk merged commit 341d4da into master Aug 9, 2023

oleksandr-pavlyk deleted the enable-operators branch August 9, 2023 20:23

ndgrigorian mentioned this pull request Aug 9, 2023

dpctl.tensor.logaddexp does not always return nan when one operand is not nan #1321

Closed

This was referenced Aug 11, 2023

Merging developmental snapshot tagged 0.14.6dev2 to gold/2021 #1337

Merged

Steps toward full compatibility with sklearnsklearn.utils.validation.check_array: missing default __array_namespace__ and dpt.isfinite #997

Closed

Enable support for Python operators in usm_ndarray class #1324

Enable support for Python operators in usm_ndarray class #1324

Uh oh!

Conversation

oleksandr-pavlyk commented Aug 2, 2023

Uh oh!

github-actions bot commented Aug 2, 2023

Uh oh!

coveralls commented Aug 3, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Aug 3, 2023

Uh oh!

github-actions bot commented Aug 3, 2023

Uh oh!

github-actions bot commented Aug 3, 2023

Uh oh!

github-actions bot commented Aug 3, 2023

Uh oh!

github-actions bot commented Aug 3, 2023

Uh oh!

github-actions bot commented Aug 6, 2023

Uh oh!

github-actions bot commented Aug 6, 2023

Uh oh!

github-actions bot commented Aug 6, 2023

Uh oh!

github-actions bot commented Aug 7, 2023

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Aug 8, 2023

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Aug 8, 2023

Uh oh!

github-actions bot commented Aug 8, 2023

Uh oh!

github-actions bot commented Aug 8, 2023

Uh oh!

oleksandr-pavlyk commented Aug 9, 2023

Uh oh!

antonwolfy commented Aug 9, 2023

Uh oh!

ndgrigorian left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Aug 9, 2023

Uh oh!

github-actions bot commented Aug 9, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

coveralls commented Aug 3, 2023 •

edited

Loading

ndgrigorian left a comment •

edited

Loading