Compile certain source files in libtensor with no-fast-math #1318
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes gh-1314 by compiling Python binding code converting
float('nan')
to a floating-point number using-fno-fast-math
.To see that this is the right solution, use
Compile it
and test with
With default compilation option
-1
comes out, signaling an uncaught exception. It takes-fno-fast-math
for it to round-trip correctly.