Skip to content

impl_minimum_maximum_elementwise_funcs #1316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
vtavana merged 2 commits into from
Aug 10, 2023
Merged

impl_minimum_maximum_elementwise_funcs #1316

vtavana merged 2 commits into from
Aug 10, 2023

Conversation

@vtavana
Copy link
Contributor

@vtavana vtavana commented Jul 31, 2023 •
edited
Loading

In this PR, elementwise maximum and minimum functions are implemented and tested.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you opening the PR as a draft?

@vtavana vtavana self-assigned this Jul 31, 2023
@github-actions
Copy link

github-actions bot commented Jul 31, 2023

View rendered docs @ https://intelpython.github.io/dpctl/pulls/1316/index.html

@coveralls
Copy link
Collaborator

coveralls commented Jul 31, 2023 •
edited
Loading

Coverage Status

coverage: 84.844% (+0.005%) from 84.839% when pulling f65e225 on impl_minimum_maximum_elementwise_funcs into acd1a60 on master.

@vtavana vtavana force-pushed the impl_minimum_maximum_elementwise_funcs branch from c7194f0 to 3eec789 Compare July 31, 2023 19:43
@github-actions
Copy link

github-actions bot commented Jul 31, 2023

Array API standard conformance tests for dpctl=0.14.6dev0=py310h7bf5fec_60 ran successfully.
Passed: 594
Failed: 406
Skipped: 119

ndgrigorian
ndgrigorian requested changes Jul 31, 2023
View reviewed changes
@github-actions
Copy link

github-actions bot commented Jul 31, 2023

Array API standard conformance tests for dpctl=0.14.6dev0=py310h7bf5fec_60 ran successfully.
Passed: 594
Failed: 406
Skipped: 119

@vtavana vtavana mentioned this pull request Aug 2, 2023
Merged
6 tasks
@vtavana vtavana force-pushed the impl_minimum_maximum_elementwise_funcs branch from 3eec789 to 751926b Compare August 2, 2023 17:10
@vtavana vtavana marked this pull request as ready for review August 2, 2023 17:11
@github-actions
Copy link

github-actions bot commented Aug 2, 2023

Array API standard conformance tests for dpctl=0.14.6dev0=py310h7bf5fec_79 ran successfully.
Passed: 612
Failed: 388
Skipped: 119

@vtavana vtavana force-pushed the impl_minimum_maximum_elementwise_funcs branch 2 times, most recently from 73568d0 to 969df7d Compare August 2, 2023 20:04
@github-actions
Copy link

github-actions bot commented Aug 2, 2023

Array API standard conformance tests for dpctl=0.14.6dev0=py310h7bf5fec_82 ran successfully.
Passed: 612
Failed: 388
Skipped: 119

1 similar comment
@github-actions
Copy link

github-actions bot commented Aug 2, 2023

Array API standard conformance tests for dpctl=0.14.6dev0=py310h7bf5fec_82 ran successfully.
Passed: 612
Failed: 388
Skipped: 119

@vtavana vtavana force-pushed the impl_minimum_maximum_elementwise_funcs branch from 969df7d to 1ac1786 Compare August 8, 2023 22:29
@github-actions
Copy link

github-actions bot commented Aug 8, 2023

Array API standard conformance tests for dpctl=0.14.6dev1=py310h7bf5fec_3 ran successfully.
Passed: 639
Failed: 361
Skipped: 119

@vtavana vtavana force-pushed the impl_minimum_maximum_elementwise_funcs branch from 1ac1786 to 28df31c Compare August 9, 2023 04:01
@github-actions
Copy link

github-actions bot commented Aug 9, 2023

Array API standard conformance tests for dpctl=0.14.6dev1=py310h7bf5fec_3 ran successfully.
Passed: 639
Failed: 361
Skipped: 119

oleksandr-pavlyk
oleksandr-pavlyk reviewed Aug 9, 2023
View reviewed changes
oleksandr-pavlyk
oleksandr-pavlyk reviewed Aug 9, 2023
View reviewed changes
@vtavana vtavana force-pushed the impl_minimum_maximum_elementwise_funcs branch from 28df31c to 0c9fbeb Compare August 9, 2023 16:26
@github-actions
Copy link

github-actions bot commented Aug 9, 2023

Array API standard conformance tests for dpctl=0.14.6dev1=py310h7bf5fec_3 ran successfully.
Passed: 639
Failed: 361
Skipped: 119

ndgrigorian
ndgrigorian reviewed Aug 9, 2023
View reviewed changes
@vtavana vtavana force-pushed the impl_minimum_maximum_elementwise_funcs branch from 0c9fbeb to f65e225 Compare August 9, 2023 20:16
@github-actions
Copy link

github-actions bot commented Aug 9, 2023

Array API standard conformance tests for dpctl=0.14.6dev1=py310h7bf5fec_3 ran successfully.
Passed: 639
Failed: 361
Skipped: 119

ndgrigorian
ndgrigorian approved these changes Aug 9, 2023
View reviewed changes
Copy link
Collaborator

@ndgrigorian ndgrigorian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this PR is ready.

Approved, thank you @vtavana .

oleksandr-pavlyk
oleksandr-pavlyk approved these changes Aug 10, 2023
View reviewed changes
Copy link
Contributor

@oleksandr-pavlyk oleksandr-pavlyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @vtavana

@vtavana vtavana merged commit b055ff9 into master Aug 10, 2023
@vtavana vtavana deleted the impl_minimum_maximum_elementwise_funcs branch August 10, 2023 00:31
@github-actions
Copy link

github-actions bot commented Aug 10, 2023

Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞

@github-actions
Copy link

github-actions bot commented Aug 10, 2023

Array API standard conformance tests for dpctl=0.14.6dev1=py310h7bf5fec_32 ran successfully.
Passed: 913
Failed: 87
Skipped: 119

@oleksandr-pavlyk oleksandr-pavlyk mentioned this pull request Aug 11, 2023
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ndgrigorian ndgrigorian ndgrigorian approved these changes

+1 more reviewer

@oleksandr-pavlyk oleksandr-pavlyk oleksandr-pavlyk approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@vtavana vtavana

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@vtavana @coveralls @oleksandr-pavlyk @ndgrigorian