Skip to content

Implements logical operators and, or, xor, and not #1270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 30, 2023
Merged

Implements logical operators and, or, xor, and not #1270

merged 3 commits into from
Jun 30, 2023

Conversation

ndgrigorian
Copy link
Collaborator

@ndgrigorian ndgrigorian commented Jun 29, 2023 •
edited
Loading

This PR implements dpctl.tensor.logical_and, dpctl.tensor.logical_or, dpctl.tensor.logical_xor, and dpctl.tensor.logical_not.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you opening the PR as a draft?

@ndgrigorian ndgrigorian requested a review from antonwolfy June 29, 2023 15:23
@ndgrigorian ndgrigorian force-pushed the logical-operators-impl branch from 5f905f8 to 47e61de Compare June 29, 2023 15:25
@github-actions
Copy link

View rendered docs @ https://intelpython.github.io/dpctl/pulls/1270/index.html

@coveralls
Copy link
Collaborator

coveralls commented Jun 29, 2023 •
edited
Loading

Coverage Status

coverage: 83.271% (+0.01%) from 83.261% when pulling 1a0231e on logical-operators-impl into 0506a49 on master.

@github-actions
Copy link

Array API standard conformance tests for dpctl=0.14.5dev0=py310h7bf5fec_6 ran successfully.
Passed: 398
Failed: 602
Skipped: 119

1 similar comment
@github-actions
Copy link

Array API standard conformance tests for dpctl=0.14.5dev0=py310h7bf5fec_6 ran successfully.
Passed: 398
Failed: 602
Skipped: 119

@antonwolfy antonwolfy force-pushed the logical-operators-impl branch from ff245a0 to 1a0231e Compare June 30, 2023 13:17
@antonwolfy antonwolfy marked this pull request as ready for review June 30, 2023 13:20
@github-actions
Copy link

Array API standard conformance tests for dpctl=0.14.5dev0=py310h7bf5fec_7 ran successfully.
Passed: 399
Failed: 601
Skipped: 119

@github-actions
Copy link

Array API standard conformance tests for dpctl=0.14.5dev0=py310h7bf5fec_7 ran successfully.
Passed: 400
Failed: 600
Skipped: 119

antonwolfy
antonwolfy approved these changes Jun 30, 2023
View reviewed changes
Copy link
Collaborator

@antonwolfy antonwolfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! thank you @ndgrigorian

@ndgrigorian ndgrigorian merged commit 7bfc5a0 into master Jun 30, 2023
@github-actions
Copy link

Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞

@github-actions
Copy link

Array API standard conformance tests for dpctl=0.14.5dev0=py310h7bf5fec_7 ran successfully.
Passed: 398
Failed: 602
Skipped: 119

@ndgrigorian ndgrigorian mentioned this pull request Jul 4, 2023
Closed
@ndgrigorian ndgrigorian deleted the logical-operators-impl branch July 27, 2023 01:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antonwolfy antonwolfy antonwolfy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ndgrigorian @coveralls @antonwolfy