Update _empty_like_pair_orderK for support arrays of different shapes #1224
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR solves #1222.
Now
_empty_like_pair_orderK
takes a newres_shape
parameter to check if the shape of the resulting array has changed after broadcasting. If the resulting array shape is not equal the shape of the input arrays,dpt.empty
will be called instead ofdpt.empty_like
.Also this PR updates the logic for stride input arrays in
_empty_like_pair_orderK
for cases of different stride list lengths. The previous implementation expectedst1
andst2
to have the same stride list length and always used theX1
array shape for the resulting array.Added tests only for
test_add
. This is enough to check for new changes and to reduce the number of test lines.