Skip to content

Fixes incorrect result when multiplying real array and complex scalar #1220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 31, 2023

Conversation

ndgrigorian
Copy link
Collaborator

Resolves #1219

Changes _resolve_weak_types to handle complex scalars properly and adds a test for the issue/fix.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you opening the PR as a draft?

@github-actions
Copy link

@coveralls
Copy link
Collaborator

Coverage Status

Coverage: 84.012%. Remained the same when pulling b03beb3 on multiply-scalar-gh-1219 into 521867b on master.

@github-actions
Copy link

Array API standard conformance tests for dpctl=0.14.3dev3=py310h7bf5fec_2 ran successfully.
Passed: 233
Failed: 767
Skipped: 116

@ndgrigorian ndgrigorian requested a review from vtavana May 30, 2023 22:54
@ndgrigorian ndgrigorian merged commit 1adbaa0 into master May 31, 2023
@github-actions
Copy link

Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞

@github-actions
Copy link

Array API standard conformance tests for dpctl=0.14.3dev3=py310h7bf5fec_6 ran successfully.
Passed: 258
Failed: 742
Skipped: 116

Copy link
Contributor

@oleksandr-pavlyk oleksandr-pavlyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you fixing this @ndgrigorian

@ndgrigorian ndgrigorian deleted the multiply-scalar-gh-1219 branch July 27, 2023 01:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dpt.multiply returns incorrect result when multiplying a real fp. array by a complex scalar
4 participants