Skip to content

Require DPC++ 2023.1.0 and later, require min version of sysroot #1195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 3, 2023

Conversation

oleksandr-pavlyk
Copy link
Contributor

This PR bumps up required version of DPC++ compiler to 2023.1.0.

It also restricts the version of sysroot that may be installed into build environment from below.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you opening the PR as a draft?

@oleksandr-pavlyk
Copy link
Contributor Author

(dev_dpctl) opavlyk@opavlyk-mobl:~/repos/users.dp-ext-team.ops-sandbox/py-unary-functions$ conda search dpcpp_impl_linux-64=2023.1.0 -c conda-forge --info
Loading channels: done
dpcpp_impl_linux-64 2023.1.0 h7ce6118_46305
-------------------------------------------
file name   : dpcpp_impl_linux-64-2023.1.0-h7ce6118_46305.conda
name        : dpcpp_impl_linux-64
version     : 2023.1.0
build       : h7ce6118_46305
build number: 46305
size        : 365.5 MB
license     : LicenseRef-Proprietary-Intel-End-User-License-Agreement-for-Developer-Tools
subdir      : linux-64
url         : https://conda.anaconda.org/conda-forge/linux-64/dpcpp_impl_linux-64-2023.1.0-h7ce6118_46305.conda
md5         : cd8d76427c823498fa997edad4e9908b
timestamp   : 2023-04-13 14:17:53 UTC
dependencies:
  - _openmp_mutex >=4.5
  - dpcpp-cpp-rt 2023.1.0 hcb278e6_46305
  - libgcc-ng >=12
  - libstdcxx-ng >=12
  - libxml2 >=2.10.4,<2.11.0a0
  - libzlib >=1.2.13,<1.3.0a0
  - ocl-icd >=2.3.1,<3.0a0
  - sysroot_linux-64 2.17.*

So according to this dependency, there is no need to restrict sysroot_linux-64 version in our meta.yaml. It is already pinned by the compiler.

@@ -13,7 +13,8 @@ build:
requirements:
build:
- {{ compiler('cxx') }}
- {{ compiler('dpcpp') }} >=2023.0 # [not osx]
- {{ compiler('dpcpp') }} >=2023.1 # [not osx]
- sysroot_linux-64 >=2.17 # [linux]
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tab here, should be spaces.

Replaced tab with spaces
@coveralls
Copy link
Collaborator

Coverage Status

Coverage: 83.259%. Remained the same when pulling 51838ac on meta-yaml-changes into cddf05f on master.

@github-actions
Copy link

github-actions bot commented May 3, 2023

@github-actions
Copy link

github-actions bot commented May 3, 2023

Array API standard conformance tests for dpctl=0.14.3dev1=py310h76be34b_36 ran successfully.
Passed: 153
Failed: 847
Skipped: 116

@oleksandr-pavlyk oleksandr-pavlyk merged commit 2da47aa into master May 3, 2023
@oleksandr-pavlyk oleksandr-pavlyk deleted the meta-yaml-changes branch May 3, 2023 17:48
@github-actions
Copy link

github-actions bot commented May 3, 2023

Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞

@github-actions
Copy link

github-actions bot commented May 3, 2023

Array API standard conformance tests for dpctl=0.14.3dev1=py310h76be34b_38 ran successfully.
Passed: 153
Failed: 847
Skipped: 116

@oleksandr-pavlyk oleksandr-pavlyk mentioned this pull request May 4, 2023
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants