-
Notifications
You must be signed in to change notification settings - Fork 30
Require DPC++ 2023.1.0 and later, require min version of sysroot #1195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
So according to this dependency, there is no need to restrict |
conda-recipe/meta.yaml
Outdated
@@ -13,7 +13,8 @@ build: | |||
requirements: | |||
build: | |||
- {{ compiler('cxx') }} | |||
- {{ compiler('dpcpp') }} >=2023.0 # [not osx] | |||
- {{ compiler('dpcpp') }} >=2023.1 # [not osx] | |||
- sysroot_linux-64 >=2.17 # [linux] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tab here, should be spaces.
Replaced tab with spaces
View rendered docs @ https://intelpython.github.io/dpctl/pulls/1195/index.html |
Array API standard conformance tests for dpctl=0.14.3dev1=py310h76be34b_36 ran successfully. |
Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞 |
Array API standard conformance tests for dpctl=0.14.3dev1=py310h76be34b_38 ran successfully. |
This PR bumps up required version of DPC++ compiler to 2023.1.0.
It also restricts the version of sysroot that may be installed into build environment from below.