Skip to content

Check that %PLATFORM_DIR% exists before copying there #1194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 3, 2023
Merged

Check that %PLATFORM_DIR% exists before copying there #1194

merged 1 commit into from
May 3, 2023

Conversation

oleksandr-pavlyk
Copy link
Contributor

Check %PLATFORM_DIR% exists before manipulating it in bld.bat`

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you opening the PR as a draft?

@oleksandr-pavlyk oleksandr-pavlyk requested a review from ekomarova May 3, 2023 13:30
@github-actions
Copy link

github-actions bot commented May 3, 2023

View rendered docs @ https://intelpython.github.io/dpctl/pulls/1194/index.html

@coveralls
Copy link
Collaborator

Coverage Status

Coverage: 83.259%. Remained the same when pulling b31c42f on bld-bat-add-platform-dir-check into cddf05f on master.

@github-actions
Copy link

github-actions bot commented May 3, 2023

Array API standard conformance tests for dpctl=0.14.3dev1=py310h76be34b_35 ran successfully.
Passed: 153
Failed: 847
Skipped: 116

@oleksandr-pavlyk oleksandr-pavlyk merged commit 4da1059 into master May 3, 2023
@oleksandr-pavlyk oleksandr-pavlyk deleted the bld-bat-add-platform-dir-check branch May 3, 2023 17:48
@github-actions
Copy link

github-actions bot commented May 3, 2023

Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞

@github-actions
Copy link

github-actions bot commented May 3, 2023

Array API standard conformance tests for dpctl=0.14.3dev1=py310h76be34b_35 ran successfully.
Passed: 153
Failed: 847
Skipped: 116

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ekomarova ekomarova Awaiting requested review from ekomarova

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@oleksandr-pavlyk @coveralls