Skip to content

Better handle no devices systems #1189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 18 commits into from
May 2, 2023

Conversation

oleksandr-pavlyk
Copy link
Contributor

Wrapped certain DPC++ RT function calls, such as sycl::device::get_devices and sycl::platform::get_platforms in try/except.

Added validation of object returned by cache builders.

Fixed typo in exception name in a Python test suite file, then run each test file individually with invalid setting of ONEAPI_DEVICE_SELECTOR=cpu to make sure the all execute fine.

All but test_sycl_queue_manager.py pass. This one hangs due to filed problem in DPC++ Runtime.

Test suite continues to run clean with unset ONEAPI_DEVICE_SELECTOR environment variable, or it being set to a valid value, i.e. ONEAPI_DEVICE_SELECTOR=*:cpu.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you opening the PR as a draft?

@github-actions
Copy link

@coveralls
Copy link
Collaborator

coveralls commented Apr 26, 2023

Coverage Status

Coverage: 83.259% (-0.08%) from 83.336% when pulling 802efbc on better-handle-no-devices-systems into 5707661 on master.

@github-actions
Copy link

Array API standard conformance tests for dpctl=0.14.3dev1=py310h76be34b_26 ran successfully.
Passed: 120
Failed: 887
Skipped: 109

@github-actions
Copy link

Array API standard conformance tests for dpctl=0.14.3dev1=py310h76be34b_27 ran successfully.
Passed: 120
Failed: 887
Skipped: 109

@github-actions
Copy link

Array API standard conformance tests for dpctl=0.14.3dev1=py310h76be34b_28 ran successfully.
Passed: 120
Failed: 887
Skipped: 109

@github-actions
Copy link

Array API standard conformance tests for dpctl=0.14.3dev1=py310h76be34b_32 ran successfully.
Passed: 120
Failed: 887
Skipped: 109

@oleksandr-pavlyk oleksandr-pavlyk force-pushed the better-handle-no-devices-systems branch 2 times, most recently from ed2d54c to 59c3027 Compare May 1, 2023 03:59
@github-actions
Copy link

github-actions bot commented May 1, 2023

Array API standard conformance tests for dpctl=0.14.3dev1=py310h76be34b_32 ran successfully.
Passed: 120
Failed: 887
Skipped: 109

Skipping test_sycl_event::test_backend in OS-LLVM-build workflow to
work around intel/llvm#9264

Renamed test_sycl_event.py::test_backend to
test_sycl_event.py::test_event_backend and excluded it from suite
run on OS SYCL-bundle-based workflow
@github-actions
Copy link

github-actions bot commented May 1, 2023

Array API standard conformance tests for dpctl=0.14.3dev1=py310h76be34b_32 ran successfully.
Passed: 120
Failed: 887
Skipped: 109

@oleksandr-pavlyk oleksandr-pavlyk force-pushed the better-handle-no-devices-systems branch from 59c3027 to 874f4fe Compare May 1, 2023 04:26
@github-actions
Copy link

github-actions bot commented May 1, 2023

Array API standard conformance tests for dpctl=0.14.3dev1=py310h76be34b_32 ran successfully.
Passed: 120
Failed: 887
Skipped: 109

@github-actions
Copy link

github-actions bot commented May 1, 2023

Array API standard conformance tests for dpctl=0.14.3dev1=py310h76be34b_33 ran successfully.
Passed: 153
Failed: 847
Skipped: 116

@oleksandr-pavlyk oleksandr-pavlyk force-pushed the better-handle-no-devices-systems branch from 531437f to 802efbc Compare May 1, 2023 17:17
@github-actions
Copy link

github-actions bot commented May 1, 2023

Array API standard conformance tests for dpctl=0.14.3dev1=py310h76be34b_33 ran successfully.
Passed: 153
Failed: 847
Skipped: 116

@oleksandr-pavlyk oleksandr-pavlyk merged commit cddf05f into master May 2, 2023
@oleksandr-pavlyk oleksandr-pavlyk deleted the better-handle-no-devices-systems branch May 2, 2023 03:52
@github-actions
Copy link

github-actions bot commented May 2, 2023

Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞

@github-actions
Copy link

github-actions bot commented May 2, 2023

Array API standard conformance tests for dpctl=0.14.3dev1=py310h76be34b_33 ran successfully.
Passed: 153
Failed: 847
Skipped: 116

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants