Simplified API for simplify_iteration_space* functions #1188
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
View rendered docs @ https://intelpython.github.io/dpctl/pulls/1188/index.html |
|
Array API standard conformance tests for dpctl=0.14.3dev1=py310h76be34b_11 ran successfully. |
oleksandr-pavlyk
force-pushed
the
streamline-iter-space-simplifier-api
branch
from
e40d6c2 to
106b919
Compare
|
Array API standard conformance tests for dpctl=0.14.3dev1=py310h76be34b_11 ran successfully. |
Modified call sites of these functions to adapt to change of API.
oleksandr-pavlyk
force-pushed
the
streamline-iter-space-simplifier-api
branch
from
106b919 to
6ed8a7a
Compare
|
Array API standard conformance tests for dpctl=0.14.3dev1=py310h76be34b_11 ran successfully. |
ndgrigorian
approved these changes
Apr 25, 2023
|
Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞 |
|
Array API standard conformance tests for dpctl=0.14.3dev1=py310h76be34b_11 ran successfully. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR simplifies calling signatures of
simplify_iteration_space*functions. Both shape pointer and input strides are const references. Passing strides as vectors obtained usingdpctl::tensor::usm_ndarray::get_strides_vector()method allows to do away with passing contiguity flags anditemsizeparameter.Also changed implementation to use STL functions rather than using custom loops for operations such as copying, or scaling.
This should improve performance of stride simplification calls.