Skip to content

Added -Wstrict-prototypes, removed -fno-strict-overflow #1131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 21, 2023

Conversation

oleksandr-pavlyk
Copy link
Contributor

Added -Wstrict-prototypes, removed -fno-strict-overflow.

-fno-strict-overflow is implied by -fwrapv and generates compiler unused option warning.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • If this PR is a work in progress, are you filing the PR as a draft?

-fno-strict-overflow is implied by -fwrapv and generates compiler unused
option warning.
@github-actions
Copy link

@coveralls
Copy link
Collaborator

coveralls commented Mar 19, 2023

Coverage Status

Coverage: 82.516%. Remained the same when pulling 4f74938 on cmake-tweaks into 2273287 on master.

@github-actions
Copy link

Array API standard conformance tests for dpctl=0.14.3dev0=py310h76be34b_2 ran successfully.
Passed: 46
Failed: 788
Skipped: 280

@github-actions
Copy link

Array API standard conformance tests for dpctl=0.14.3dev0=py310h76be34b_4 ran successfully.
Passed: 46
Failed: 788
Skipped: 280

@oleksandr-pavlyk oleksandr-pavlyk merged commit 1a6bba0 into master Mar 21, 2023
@oleksandr-pavlyk oleksandr-pavlyk deleted the cmake-tweaks branch March 21, 2023 20:50
@github-actions
Copy link

Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞

@github-actions
Copy link

Array API standard conformance tests for dpctl=0.14.3dev0=py310h76be34b_12 ran successfully.
Passed: 46
Failed: 788
Skipped: 280

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants