Skip to content

Make dependency of _usmarray.pyx on *.pxi files explicit in cmake #1112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 13, 2023

Conversation

oleksandr-pavlyk
Copy link
Contributor

"dpctl/tensor/_usmarray.pyx" includes several *.pxi files, but this dependency was not reflect in cmake script.

This PR addresses that oversight.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • If this PR is a work in progress, are you filing the PR as a draft?

@github-actions
Copy link

@coveralls
Copy link
Collaborator

Coverage Status

Coverage: 82.404%. Remained the same when pulling 9da8978 on add-pxi-dependencies into 51863d4 on master.

@github-actions
Copy link

Array API standard conformance tests for dpctl=0.14.2=py310h76be34b_30 ran successfully.
Passed: 46
Failed: 788
Skipped: 280

@oleksandr-pavlyk oleksandr-pavlyk merged commit ad8ed63 into master Mar 13, 2023
@oleksandr-pavlyk oleksandr-pavlyk deleted the add-pxi-dependencies branch March 13, 2023 22:39
@github-actions
Copy link

Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞

@github-actions
Copy link

Array API standard conformance tests for dpctl=0.14.2=py310h76be34b_37 ran successfully.
Passed: 46
Failed: 788
Skipped: 280

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants