Skip to content

This PR modifies conda-recipe to add post-link to dpctl #1081

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 22, 2023

Conversation

oleksandr-pavlyk
Copy link
Contributor

The post-link creates a symbolic link from $PREFIX/etc/OpenCL/vendors/intel-gpu.icd to /etc/OpenCL/vendors/intel.icd if one exists.

This is a work-around to ensure that OpenCL GPU device from system installation can be found by OpenCL loader in intel-opencl-rt forthcoming package.

  • Have you provided a meaningful PR description?

@github-actions
Copy link

antonwolfy
antonwolfy previously approved these changes Feb 22, 2023
Copy link
Collaborator

@antonwolfy antonwolfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@oleksandr-pavlyk , thank you! LGTM!

@coveralls
Copy link
Collaborator

coveralls commented Feb 22, 2023

Coverage Status

Coverage: 82.316%. Remained the same when pulling 7dc575a on add-post-link into bdeb37d on master.

@github-actions
Copy link

Array API standard conformance tests for dpctl=0.14.1dev2=py310h76be34b_41 ran successfully.
Passed: 33
Failed: 801
Skipped: 280

The post-link creates a symbolic link from $PREFIX/etc/OpenCL/vendors/intel-gpu.icd to /etc/OpenCL/vendors/intel.icd if one exists.

This is a work-around to ensure that OpenCL GPU device from system
installation can be found by OpenCL loader in intel-opencl-rt forthcoming
package.
@github-actions
Copy link

Array API standard conformance tests for dpctl=0.14.1dev2=py310h76be34b_41 ran successfully.
Passed: 33
Failed: 801
Skipped: 280

@oleksandr-pavlyk
Copy link
Contributor Author

Verified that conda package artifacts work locally. Merging now.

@oleksandr-pavlyk oleksandr-pavlyk merged commit 79fbb79 into master Feb 22, 2023
@oleksandr-pavlyk oleksandr-pavlyk deleted the add-post-link branch February 22, 2023 22:44
@github-actions
Copy link

Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞

@github-actions
Copy link

Array API standard conformance tests for dpctl=0.14.1dev2=py310h76be34b_41 ran successfully.
Passed: 33
Failed: 801
Skipped: 280

oleksandr-pavlyk added a commit that referenced this pull request Feb 23, 2023
conda prunes empty folders, so the dpctl tar-ball did not contain
empty etc/OpenCL/vendors folder. Solved by create a dummy `.dpctl_readme`
file in that folder.

The script dpctl-post-link.sh contained a type in the filename it was checking
should not exist.
oleksandr-pavlyk added a commit that referenced this pull request Feb 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants