Skip to content

Native vector width device descriptors #1075

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Feb 17, 2023

Conversation

oleksandr-pavlyk
Copy link
Contributor

Exposed DPCTLDevice_GetNativeVectorWidthChar and friends in DPCTLSyclInterface library.

Added dpctl.SyclDevice properties to query native vector widths for different types per SYCL spec. Supported types align with preferred_vector_width_* properties and include char, short, int, long, float, double, and half.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • If this PR is a work in progress, are you filing the PR as a draft?

mingjie-intel
mingjie-intel previously approved these changes Feb 17, 2023
Copy link

@mingjie-intel mingjie-intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes looks good. Thanks!

@github-actions
Copy link

@coveralls
Copy link
Collaborator

coveralls commented Feb 17, 2023

Coverage Status

Coverage: 82.304% (+0.03%) from 82.269% when pulling a7c468c on native-vector-width-device-descriptors into 0a8abd8 on master.

@github-actions
Copy link

Array API standard conformance tests for dpctl=0.14.1dev2=py310h41425db_21 ran successfully.
Passed: 32
Failed: 802
Skipped: 280

@oleksandr-pavlyk
Copy link
Contributor Author

@mingjie-intel I had added checks for new device descriptor properties but did not register them with the fixture.

@github-actions
Copy link

Array API standard conformance tests for dpctl=0.14.1dev2=py310h41425db_22 ran successfully.
Passed: 33
Failed: 801
Skipped: 280

@oleksandr-pavlyk oleksandr-pavlyk merged commit ecbe8fb into master Feb 17, 2023
@oleksandr-pavlyk oleksandr-pavlyk deleted the native-vector-width-device-descriptors branch February 17, 2023 23:46
@github-actions
Copy link

Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞

@github-actions
Copy link

Array API standard conformance tests for dpctl=0.14.1dev2=py310h41425db_22 ran successfully.
Passed: 33
Failed: 801
Skipped: 280

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants