Changes the API for DPCTLUSM_GetPointerType. #1061
Conversation
|
Array API standard conformance tests for dpctl=0.14.1dev1=py310h76be34b_77 ran successfully. |
oleksandr-pavlyk
left a comment
oleksandr-pavlyk
left a comment
There was a problem hiding this comment.
LGTM! Thanks @diptorupd
|
View rendered docs @ https://intelpython.github.io/dpctl/pulls/1061/index.html |
diptorupd
force-pushed
the
fix/DPCTLUSM_GetPointerType
branch
from
86be4cf to
2492420
Compare
|
Array API standard conformance tests for dpctl=0.14.1dev1=py310h76be34b_77 ran successfully. |
diptorupd
force-pushed
the
fix/DPCTLUSM_GetPointerType
branch
from
50196bc to
065e28e
Compare
|
Array API standard conformance tests for dpctl=0.14.1dev1=py310h76be34b_77 ran successfully. |
|
Array API standard conformance tests for dpctl=0.14.1dev1=py310h76be34b_78 ran successfully. |
- DPCTLUSM_GetPointerType used to return a global string literal
and had an API that is different from all other libsyclinterface
functions that return a C string.
Returning a pointer to a global literal as opposed to a heap
allocated memory meant the ownership of the pointer was not
clear when crossing language boundary.
Calling DPCTLCString_Delete on the previously returned const char*
will cause a segfault
- The PR introduces an enum for usm types and returns an enum value
from DPCTLUSM_GetPointerType.
- All Python API is unaffected.
diptorupd
force-pushed
the
fix/DPCTLUSM_GetPointerType
branch
from
1310d09 to
e75f13b
Compare
|
Array API standard conformance tests for dpctl=0.14.1dev1=py310h76be34b_77 ran successfully. |
|
Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞 |
|
Array API standard conformance tests for dpctl=0.14.1dev1=py310h76be34b_77 ran successfully. |
3 participants
Have you provided a meaningful PR description?
DPCTLUSM_GetPointerType used to return a global string literal
and had an API that is different from all other libsyclinterface
functions that return a C string.
Returning a pointer to a global literal as opposed to a heap
allocated memory meant the ownership of the pointer was not
clear when crossing language boundary.
Calling DPCTLCString_Delete on the previously returned const char*
will cause a segfault
The PR introduces an enum for usm types and returns an enum value
from DPCTLUSM_GetPointerType.
All Python API is unaffected.
Have you added a test, reproducer or referred to an issue with a reproducer?
Existing unit tests have been updated.
No
Yes