Multi-definition issue of including the DPCTL header in multiple CPP sources

[chengjunlu]

Hi,

I have two CPP sources include the DPCTL header.
The multi-definition issue happen in linking:

/usr/bin/ld: /tmp/Stream-e835c3.o: in function `std::__detail::_Hash_node<std::pair<_object const* const, std::vector<_object*, std::allocator<_object*> > >, false>::_M_next() const':
/home/guangyey/CLionProjects/pytorch/torch/include/pybind11/pybind11.h:662: multiple definition of `import_dpctl()'; /tmp/Module-08230d.o:/home/guangyey/CLionProjects/pytorch/torch/include/pybind11/pybind11.h:662: first defined here

I can work around the issue by change the import_dpctl to static.

[diptorupd]

@chengjunlu Current master should already have the fix. Can you try the latest development snapshot package? The package will need to be installed via Conda.

Refer https://github.com/IntelPython/dpctl#installing-the-bleeding-edge

[chengjunlu]

@diptorupd Thanks for the suggestion.
I met the issue on the latest master trunk commit ab46d49.

[oleksandr-pavlyk]

The fix has been merged to master in 59980a2 in #941, which happened after ab46d49

Could you please try either tip of the main branch or 59980a2 ?

[chengjunlu]

I am not sure what is suggested.

I am using the DPCTL by build it from sources instead of installing from the conda or pip

[oleksandr-pavlyk]

@chengjunlu I am suggesting you build dpctl from sources at the present tip of the master at 36c8f71. The problem you are reporting should be fixed there.

[diptorupd]

ping @chengjunlu. Does current tip of master work for you? Once you let us know we can close the ticket.

[chengjunlu]

@diptorupd
Confirmed the issue has been fixed on the latest master.
Please close this JIRA.

[oleksandr-pavlyk]

Closing as fixed by #941