Closed
Description
(py39) [12:36:38 ansatnuc04 dpctl]$ clang++ --version
clang version 14.0.0 (https://github.com/intel/llvm 7c17ad9a2bfbf6ff2757f8c7fbd2939841f35fa5)
Target: x86_64-unknown-linux-gnu
Thread model: posix
InstalledDir: /localdisk/work/opavlyk/sycl_workspace/llvm/build/bin
(py39) [12:38:10 ansatnuc04 dpctl]$ git log -1 --oneline
18b56cf (HEAD -> master, tag: 0.10.0rc3, origin/release0.10, origin/master, origin/HEAD) Update CHANGELOG for 0.10 (#590)
python setup.py develop --sycl-compiler-prefix=$(dirname $(dirname `which clang++`))
fails with compilation errors due to removal of sycl::vector_class
:
[ 23%] Building CXX object CMakeFiles/DPCTLSyclInterface.dir/source/dpctl_sycl_device_manager.cpp.o
[ 29%] Building CXX object CMakeFiles/DPCTLSyclInterface.dir/source/dpctl_sycl_device_selector_interface.cpp.o
/localdisk/work/opavlyk/interop/dpctl/dpctl-capi/source/dpctl_sycl_context_interface.cpp:39:36: error: no template named 'vector_class'
DEFINE_SIMPLE_CONVERSION_FUNCTIONS(vector_class<DPCTLSyclDeviceRef>,
^
/localdisk/work/opavlyk/interop/dpctl/dpctl-capi/source/dpctl_sycl_device_interface.cpp:43:36: error: no template named 'vector_class'
DEFINE_SIMPLE_CONVERSION_FUNCTIONS(vector_class<DPCTLSyclDeviceRef>,
^
I wonder if we could use vector_class_t
which we would define as sycl::vector_class
for older compilers, and std::vector
for newer.
#if __SYCL_COMPILER_VERSION < 20210925
template <typename T>
using vector_class_t = sycl::vector_class<T>;
#else
template <typename T>
using vector_class_t = std::vector<T>;
#endif
and then use vector_class_t
throughout.
Metadata
Metadata
Assignees
Labels
No labels