Feature/required framework packages #351
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adarshyoga
suggested changes
May 3, 2024
Contributor
adarshyoga
left a comment
adarshyoga
left a comment
There was a problem hiding this comment.
Overall PR looks great. Just one addition to the required packages in numba_cuda_framework.py. Also, dpcpp_framework.py needs to have dpctl as a required package.
|
|
||
| @staticmethod | ||
| def required_packages() -> list[str]: | ||
| return ["cupy"] |
Contributor
There was a problem hiding this comment.
Suggested change
| return ["cupy"] | |
| return ["cupy", "numba"] |
Contributor
Author
There was a problem hiding this comment.
We require numba and dpctl at package level. Idea is to ignore optional frameworks. Once we remove dp* dependencies from dpbench we can add numba, dpctl and so on
adarshyoga
approved these changes
May 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add experimental flag to
polybench,npbenchandrodinia. Add required packages to the framework. If they are not found in the environment framework simply getting disabled with a single warning message. It is much cleaner output, compare to error message on every benchmark + implementation pair that tries to run the benchmarkCloses #297
Closes #298
Closes #220