Run test on attack with lowest loss

[dxoigmn]

For some schedulers, like cosine, it possible for an attack at a prior step, and not the final step, to have a lower loss. We should keep track of the lowest train (or validation) loss attack and use that in the final step.

This is probably best done in conjunction with #11.

[adarshan-intel]

@dxoigmn According to this issue we can have track of lowest loss by updating the GCGScheduler class of schedulers.py file to track the lowest loss. #39

But where exactly do we have to use this loss?

1. Should I be logging the final loss in the attack.py file (train function)
2. Or In the title it is written Run test so should I be adding tests like in the test/test_schedulers.py file ?

Can you clarify?

[dxoigmn]

My guess this is best done in the attack loop and not the scheduler. I believe in the attack loop we already compute a loss and periodically save the state of the attack. So the best of those just need to be saved and used in the final test.

[adarshan-intel]

PR #39 has been updated