Skip to content

Commit

Permalink
ACPICA: Debugger: Split debugger initialization/termination APIs
Browse files Browse the repository at this point in the history
ACPICA commit 7a3f22baab000b186779dac64ad71d9776b8f432

It is likely that the debugger is enabled only when a userspace program
explicitly tells a kernel to do so, so it shouldn't be initialized as
early as current implementation.

The only tool requiring ACPI_DEBUGGER is acpiexec, so acpiexec need to call
the new APIs by itself. And BSD developers may also get notified to invoke
the APIs for DDB enabling. Lv Zheng.

This patch doesn't affect Linux kernel as debugger is currently not enabled
in the Linux kernel.

Link: acpica/acpica@7a3f22ba
Signed-off-by: Lv Zheng <lv.zheng@intel.com>
Signed-off-by: Bob Moore <robert.moore@intel.com>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
  • Loading branch information
Lv Zheng authored and rafaeljw committed Aug 25, 2015
1 parent cff9406 commit f8fb4c3
Show file tree
Hide file tree
Showing 4 changed files with 3 additions and 22 deletions.
4 changes: 0 additions & 4 deletions drivers/acpi/acpica/acdebug.h
Original file line number Diff line number Diff line change
Expand Up @@ -77,10 +77,6 @@ struct acpi_db_execute_walk {
/*
* dbxface - external debugger interfaces
*/
acpi_status acpi_db_initialize(void);

void acpi_db_terminate(void);

acpi_status
acpi_db_single_step(struct acpi_walk_state *walk_state,
union acpi_parse_object *op, u32 op_type);
Expand Down
7 changes: 0 additions & 7 deletions drivers/acpi/acpica/utxface.c
Original file line number Diff line number Diff line change
Expand Up @@ -92,13 +92,6 @@ acpi_status __init acpi_terminate(void)

acpi_ut_mutex_terminate();

#ifdef ACPI_DEBUGGER

/* Shut down the debugger */

acpi_db_terminate();
#endif

/* Now we can shutdown the OS-dependent layer */

status = acpi_os_terminate();
Expand Down
11 changes: 0 additions & 11 deletions drivers/acpi/acpica/utxfinit.c
Original file line number Diff line number Diff line change
Expand Up @@ -124,17 +124,6 @@ acpi_status __init acpi_initialize_subsystem(void)
return_ACPI_STATUS(status);
}

/* If configured, initialize the AML debugger */

#ifdef ACPI_DEBUGGER
status = acpi_db_initialize();
if (ACPI_FAILURE(status)) {
ACPI_EXCEPTION((AE_INFO, status,
"During Debugger initialization"));
return_ACPI_STATUS(status);
}
#endif

return_ACPI_STATUS(AE_OK);
}

Expand Down
3 changes: 3 additions & 0 deletions include/acpi/acpixf.h
Original file line number Diff line number Diff line change
Expand Up @@ -917,6 +917,9 @@ ACPI_DBG_DEPENDENT_RETURN_VOID(void
ACPI_APP_DEPENDENT_RETURN_VOID(ACPI_PRINTF_LIKE(1)
void ACPI_INTERNAL_VAR_XFACE
acpi_log_error(const char *format, ...))
acpi_status acpi_initialize_debugger(void);

void acpi_terminate_debugger(void);

/*
* Divergences
Expand Down

0 comments on commit f8fb4c3

Please sign in to comment.