Skip to content

Commit

Permalink
ide: remove try_to_identify() wrapper
Browse files Browse the repository at this point in the history
There should be no functional changes caused by this patch.

Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
  • Loading branch information
bzolnier committed Mar 24, 2009
1 parent f77e03c commit a182807
Showing 1 changed file with 9 additions and 25 deletions.
34 changes: 9 additions & 25 deletions drivers/ide/ide-probe.c
Original file line number Diff line number Diff line change
Expand Up @@ -250,7 +250,7 @@ static void do_identify(ide_drive_t *drive, u8 cmd)
}

/**
* actual_try_to_identify - send ata/atapi identify
* try_to_identify - send ATA/ATAPI identify
* @drive: drive to identify
* @cmd: command to use
*
Expand All @@ -262,7 +262,7 @@ static void do_identify(ide_drive_t *drive, u8 cmd)
* 2 device aborted the command (refused to identify itself)
*/

static int actual_try_to_identify (ide_drive_t *drive, u8 cmd)
static int try_to_identify(ide_drive_t *drive, u8 cmd)
{
ide_hwif_t *hwif = drive->hwif;
struct ide_io_ports *io_ports = &hwif->io_ports;
Expand All @@ -271,6 +271,13 @@ static int actual_try_to_identify (ide_drive_t *drive, u8 cmd)
unsigned long timeout;
u8 s = 0, a = 0;

/*
* Disable device IRQ. Otherwise we'll get spurious interrupts
* during the identify phase that the IRQ handler isn't expecting.
*/
if (io_ports->ctl_addr)
tp_ops->set_irq(hwif, 0);

/* take a deep breath */
msleep(50);

Expand Down Expand Up @@ -327,29 +334,6 @@ static int actual_try_to_identify (ide_drive_t *drive, u8 cmd)
return rc;
}

/**
* try_to_identify - try to identify a drive
* @drive: drive to probe
* @cmd: command to use
*
* Issue the identify command.
*/

static int try_to_identify (ide_drive_t *drive, u8 cmd)
{
ide_hwif_t *hwif = drive->hwif;
const struct ide_tp_ops *tp_ops = hwif->tp_ops;

/*
* Disable device IRQ. Otherwise we'll get spurious interrupts
* during the identify phase that the IRQ handler isn't expecting.
*/
if (hwif->io_ports.ctl_addr)
tp_ops->set_irq(hwif, 0);

return actual_try_to_identify(drive, cmd);
}

int ide_busy_sleep(ide_hwif_t *hwif, unsigned long timeout, int altstatus)
{
u8 stat;
Expand Down

0 comments on commit a182807

Please sign in to comment.