Skip to content

Commit

Permalink
pata_ninja32: Avoid corrupting status flags
Browse files Browse the repository at this point in the history
Ninja32 needs to set some flags to indicate it does 32bit IO. However it currently assigns this which
loses the initializing flag and causes a warning spew. Fix it to use a logical or as is intended.

Signed-off-by: Alan Cox <alan@linux.intel.com>
Tested-by: Ellmar Stelnberger <estellnb@elstel.org>
Signed-off-by: Tejun Heo <tj@kernel.org>
  • Loading branch information
Alan Cox authored and htejun committed Aug 30, 2016
1 parent 9b4b3f6 commit 9ebae9e
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/ata/pata_ninja32.c
Original file line number Diff line number Diff line change
Expand Up @@ -144,7 +144,7 @@ static int ninja32_init_one(struct pci_dev *dev, const struct pci_device_id *id)
ap->ioaddr.altstatus_addr = base + 0x1E;
ap->ioaddr.bmdma_addr = base;
ata_sff_std_ports(&ap->ioaddr);
ap->pflags = ATA_PFLAG_PIO32 | ATA_PFLAG_PIO32CHANGE;
ap->pflags |= ATA_PFLAG_PIO32 | ATA_PFLAG_PIO32CHANGE;

ninja32_program(base);
/* FIXME: Should we disable them at remove ? */
Expand Down

0 comments on commit 9ebae9e

Please sign in to comment.