Skip to content

Commit

Permalink
x86/ima: check EFI SetupMode too
Browse files Browse the repository at this point in the history
Checking "SecureBoot" mode is not sufficient, also check "SetupMode".

Fixes: 399574c ("x86/ima: retry detecting secure boot mode")
Reported-by: Matthew Garrett <mjg59@google.com>
Signed-off-by: Mimi Zohar <zohar@linux.ibm.com>
  • Loading branch information
mimizohar committed May 30, 2019
1 parent 8cdc23a commit 980ef4d
Showing 1 changed file with 10 additions and 2 deletions.
12 changes: 10 additions & 2 deletions arch/x86/kernel/ima_arch.c
Original file line number Diff line number Diff line change
Expand Up @@ -11,10 +11,11 @@ extern struct boot_params boot_params;
static enum efi_secureboot_mode get_sb_mode(void)
{
efi_char16_t efi_SecureBoot_name[] = L"SecureBoot";
efi_char16_t efi_SetupMode_name[] = L"SecureBoot";
efi_guid_t efi_variable_guid = EFI_GLOBAL_VARIABLE_GUID;
efi_status_t status;
unsigned long size;
u8 secboot;
u8 secboot, setupmode;

size = sizeof(secboot);

Expand All @@ -36,7 +37,14 @@ static enum efi_secureboot_mode get_sb_mode(void)
return efi_secureboot_mode_unknown;
}

if (secboot == 0) {
size = sizeof(setupmode);
status = efi.get_variable(efi_SetupMode_name, &efi_variable_guid,
NULL, &size, &setupmode);

if (status != EFI_SUCCESS) /* ignore unknown SetupMode */
setupmode = 0;

if (secboot == 0 || setupmode == 1) {
pr_info("ima: secureboot mode disabled\n");
return efi_secureboot_mode_disabled;
}
Expand Down

0 comments on commit 980ef4d

Please sign in to comment.