Skip to content

Commit

Permalink
PM: sleep: core: Rename dev_pm_may_skip_resume()
Browse files Browse the repository at this point in the history
The name of dev_pm_may_skip_resume() may be easily confused with the
power.may_skip_resume flag which is not checked by that function, so
rename the former as dev_pm_skip_resume().

No functional impact.

Suggested-by: Alan Stern <stern@rowland.harvard.edu>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Acked-by: Alan Stern <stern@rowland.harvard.edu>
Acked-by: Bjorn Helgaas <bhelgaas@google.com>
  • Loading branch information
rafaeljw committed Apr 24, 2020
1 parent 0fe8a1b commit 76c70cb
Show file tree
Hide file tree
Showing 6 changed files with 12 additions and 12 deletions.
2 changes: 1 addition & 1 deletion Documentation/power/pci.rst
Original file line number Diff line number Diff line change
Expand Up @@ -1034,7 +1034,7 @@ device to be left in suspend after system-wide transitions to the working state.
This flag is checked by the PM core, but the PCI bus type informs the PM core
which devices may be left in suspend from its perspective (that happens during
the "noirq" phase of system-wide suspend and analogous transitions) and next it
uses the dev_pm_may_skip_resume() helper to decide whether or not to return from
uses the dev_pm_skip_resume() helper to decide whether or not to return from
pci_pm_resume_noirq() and pci_pm_resume_early() upfront.

3.2. Device Runtime Power Management
Expand Down
4 changes: 2 additions & 2 deletions drivers/acpi/acpi_lpss.c
Original file line number Diff line number Diff line change
Expand Up @@ -1093,7 +1093,7 @@ static int acpi_lpss_resume_early(struct device *dev)
if (pdata->dev_desc->resume_from_noirq)
return 0;

if (dev_pm_may_skip_resume(dev))
if (dev_pm_skip_resume(dev))
return 0;

return acpi_lpss_do_resume_early(dev);
Expand All @@ -1105,7 +1105,7 @@ static int acpi_lpss_resume_noirq(struct device *dev)
int ret;

/* Follow acpi_subsys_resume_noirq(). */
if (dev_pm_may_skip_resume(dev))
if (dev_pm_skip_resume(dev))
return 0;

ret = pm_generic_resume_noirq(dev);
Expand Down
4 changes: 2 additions & 2 deletions drivers/acpi/device_pm.c
Original file line number Diff line number Diff line change
Expand Up @@ -1127,7 +1127,7 @@ EXPORT_SYMBOL_GPL(acpi_subsys_suspend_noirq);
*/
static int acpi_subsys_resume_noirq(struct device *dev)
{
if (dev_pm_may_skip_resume(dev))
if (dev_pm_skip_resume(dev))
return 0;

return pm_generic_resume_noirq(dev);
Expand All @@ -1145,7 +1145,7 @@ static int acpi_subsys_resume_early(struct device *dev)
{
int ret;

if (dev_pm_may_skip_resume(dev))
if (dev_pm_skip_resume(dev))
return 0;

ret = acpi_dev_resume(dev);
Expand Down
8 changes: 4 additions & 4 deletions drivers/base/power/main.c
Original file line number Diff line number Diff line change
Expand Up @@ -562,7 +562,7 @@ static void dpm_watchdog_clear(struct dpm_watchdog *wd)
/*------------------------- Resume routines -------------------------*/

/**
* dev_pm_may_skip_resume - System-wide device resume optimization check.
* dev_pm_skip_resume - System-wide device resume optimization check.
* @dev: Target device.
*
* Return:
Expand All @@ -572,7 +572,7 @@ static void dpm_watchdog_clear(struct dpm_watchdog *wd)
* - The logical negation of %power.must_resume otherwise (that is, when the
* transition under way is RESUME).
*/
bool dev_pm_may_skip_resume(struct device *dev)
bool dev_pm_skip_resume(struct device *dev)
{
if (pm_transition.event == PM_EVENT_RESTORE)
return false;
Expand Down Expand Up @@ -611,7 +611,7 @@ static int device_resume_noirq(struct device *dev, pm_message_t state, bool asyn
if (!dpm_wait_for_superior(dev, async))
goto Out;

skip_resume = dev_pm_may_skip_resume(dev);
skip_resume = dev_pm_skip_resume(dev);
/*
* If the driver callback is skipped below or by the middle layer
* callback and device_resume_early() also skips the driver callback for
Expand Down Expand Up @@ -797,7 +797,7 @@ static int device_resume_early(struct device *dev, pm_message_t state, bool asyn
if (callback)
goto Run;

if (dev_pm_may_skip_resume(dev))
if (dev_pm_skip_resume(dev))
goto Skip;

if (dev->driver && dev->driver->pm) {
Expand Down
4 changes: 2 additions & 2 deletions drivers/pci/pci-driver.c
Original file line number Diff line number Diff line change
Expand Up @@ -891,7 +891,7 @@ static int pci_pm_resume_noirq(struct device *dev)
pci_power_t prev_state = pci_dev->current_state;
bool skip_bus_pm = pci_dev->skip_bus_pm;

if (dev_pm_may_skip_resume(dev))
if (dev_pm_skip_resume(dev))
return 0;

/*
Expand Down Expand Up @@ -920,7 +920,7 @@ static int pci_pm_resume_noirq(struct device *dev)

static int pci_pm_resume_early(struct device *dev)
{
if (dev_pm_may_skip_resume(dev))
if (dev_pm_skip_resume(dev))
return 0;

return pm_generic_resume_early(dev);
Expand Down
2 changes: 1 addition & 1 deletion include/linux/pm.h
Original file line number Diff line number Diff line change
Expand Up @@ -758,7 +758,7 @@ extern int pm_generic_poweroff_late(struct device *dev);
extern int pm_generic_poweroff(struct device *dev);
extern void pm_generic_complete(struct device *dev);

extern bool dev_pm_may_skip_resume(struct device *dev);
extern bool dev_pm_skip_resume(struct device *dev);
extern bool dev_pm_smart_suspend_and_suspended(struct device *dev);

#else /* !CONFIG_PM_SLEEP */
Expand Down

0 comments on commit 76c70cb

Please sign in to comment.