Skip to content

Commit

Permalink
signal/bpfilter: Fix bpfilter_kernl to use send_sig not force_sig
Browse files Browse the repository at this point in the history
The locking in force_sig_info is not prepared to deal with
a task that exits or execs (as sighand may change).  As force_sig
is only built to handle synchronous exceptions.

Further the function force_sig_info changes the signal state if the
signal is ignored, or blocked or if SIGNAL_UNKILLABLE will prevent the
delivery of the signal.  The signal SIGKILL can not be ignored and can
not be blocked and SIGNAL_UNKILLABLE won't prevent it from being
delivered.

So using force_sig rather than send_sig for SIGKILL is pointless.

Because it won't impact the sending of the signal and and because
using force_sig is wrong, replace force_sig with send_sig.

Cc: Alexei Starovoitov <ast@kernel.org>
Cc: David S. Miller <davem@davemloft.net>
Fixes: d2ba09c ("net: add skeleton of bpfilter kernel module")
Signed-off-by: "Eric W. Biederman" <ebiederm@xmission.com>
  • Loading branch information
ebiederm committed May 27, 2019
1 parent fee1099 commit 1dfd171
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion net/bpfilter/bpfilter_kern.c
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ static void shutdown_umh(void)

tsk = get_pid_task(find_vpid(bpfilter_ops.info.pid), PIDTYPE_PID);
if (tsk) {
force_sig(SIGKILL, tsk);
send_sig(SIGKILL, tsk, 1);
put_task_struct(tsk);
}
}
Expand Down

0 comments on commit 1dfd171

Please sign in to comment.