Выгрузка таблицы со статистикой в Google Docs #209
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DedSec256
force-pushed
the
google-sheets
branch
2 times, most recently
from
c59e9ab to
ce2e81c
Compare
| else return Result.Failed("Некорректная ссылка"); | ||
| } | ||
|
|
||
| private Result parseGoogleSheetLink(SheetUrl sheetUrl) |
There was a problem hiding this comment.
В C# методы всегда именуются с заглавной вроде
| return (valueRange, range); | ||
| } | ||
|
|
||
|
|
There was a problem hiding this comment.
Лишняя пустая строчка, и некое массовое отсутствие комментариев
|
|
||
| public int Column { get; set; } | ||
|
|
||
| public Position(int rowPosition, int ColumnPosition) |
There was a problem hiding this comment.
- Параметры именуются со строчной
- Когда HwProj откажется от древнего .NET Core, это может стать record-ом
| public void CheckTheEquivalenceOfTwoSheetsValues() | ||
| { | ||
| var result = ExcelGenerator.Generate(courseMatesModels, course, sheetName); | ||
| using (MemoryStream memoryStream = new MemoryStream(result)) |
| var result = ExcelGenerator.Generate(courseMatesModels, course, sheetName); | ||
| using (MemoryStream memoryStream = new MemoryStream(result)) | ||
| { | ||
| ExcelPackage package = new ExcelPackage(); |
Comment on lines
237
to
240
| comparer = new Func<ExcelRange, ExcelRange, bool>((firstCell, secondCell) => | ||
| { | ||
| return Equals(firstCell.Value, secondCell.Value); | ||
| }); |
There was a problem hiding this comment.
comparer = new Func<ExcelRange, ExcelRange, bool>((firstCell, secondCell) =>
Equals(firstCell.Value, secondCell.Value));
YuriUfimtsev
force-pushed
the
google-sheets
branch
from
75dc8c0 to
77dff88
Compare
YuriUfimtsev
force-pushed
the
google-sheets
branch
from
840f5cf to
86589e7
Compare
|
@YuriUfimtsev, можешь отребейзить, пожалуйста? |
YuriUfimtsev
force-pushed
the
google-sheets
branch
from
66d117c to
7dca217
Compare
|
@DedSec256, done |
DedSec256
force-pushed
the
google-sheets
branch
2 times, most recently
from
3566360 to
7dca217
Compare
YuriUfimtsev
force-pushed
the
google-sheets
branch
from
d0e0291 to
78ac8bc
Compare
bygu4
force-pushed
the
google-sheets
branch
2 times, most recently
from
9147934 to
aa30dc9
Compare
…w download errors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR содержит реализацию функциональности по выгрузке статистики решений в Google-таблицы, на Яндекс Диск и путем загрузки файла.