Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Python 3 syntax back to 3.0 #261

Merged
merged 13 commits into from
Mar 20, 2020
Merged

Support Python 3 syntax back to 3.0 #261

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
522eb5e
Add detecting future imports to config.
thatch Nov 10, 2019
0c7d8b4
Plumb through future_imports
thatch Dec 25, 2019
5b83c63
Add ability to test at a specific version
thatch Mar 9, 2020
2a3703e
Simplify allowed `python_version`s, add 3.3
thatch Nov 10, 2019
9d0a2be
[parsing 3.3] Matrix multiply (PEP 465)
thatch Nov 10, 2019
a65cb06
[parsing 3.3] async def (PEP 492)
thatch Nov 10, 2019
21ca166
[parsing 3.3] Unpacking generalizations (PEP 448)
thatch Nov 11, 2019
f17bde3
[parsing 3.3] yield from (PEP 380)
thatch Jan 8, 2020
0bde0ce
[parsing 3.3] disallow u-prefix strings from 3.0 to 3.2
thatch Jan 8, 2020
8053cdb
[parsing 3.1] with multiple items
thatch Jan 8, 2020
dc9dcfe
Update README to specify 3.0+ versions work
thatch Jan 8, 2020
f961f7e
Shorter name for KNOWN_PYTHON_VERSION_STRINGS
thatch Mar 9, 2020
62fd4e5
Change annotation to make type checker happy
thatch Mar 10, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Simplify allowed python_versions, add 3.3
  • Loading branch information
@thatch
thatch committed Mar 12, 2020
commit 2a3703ec0adeb98cbb572fee3ece108fdc3c682a
16 changes: 9 additions & 7 deletions libcst/_parser/types/config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,9 @@ def __repr__(self) -> str:
return str(self)


KNOWN_PYTHON_VERSION_STRINGS = ["3.3", "3.5", "3.6", "3.7", "3.8"]


@add_slots
@dataclass(frozen=True)
class PartialParserConfig:
Expand All @@ -84,7 +87,7 @@ class PartialParserConfig:
#: run LibCST. For example, you can parse code as 3.7 with a CPython 3.6
#: interpreter.
#:
#: Currently, only Python 3.5, 3.6, 3.7 and 3.8 syntax is supported.
#: Currently, only Python 3.3, 3.5, 3.6, 3.7 and 3.8 syntax is supported.
python_version: Union[str, AutoConfig] = AutoConfig.token

#: A named tuple with the ``major`` and ``minor`` Python version numbers. This is
Expand Down Expand Up @@ -121,15 +124,14 @@ def __post_init__(self) -> None:

# Once we add support for more versions of Python, we can change this to detect
# the supported version range.
if parsed_python_version not in (
PythonVersionInfo(3, 5),
PythonVersionInfo(3, 6),
PythonVersionInfo(3, 7),
PythonVersionInfo(3, 8),
if not any(
parsed_python_version == parse_version_string(v)
for v in KNOWN_PYTHON_VERSION_STRINGS
):
comma_versions = ", ".join(KNOWN_PYTHON_VERSION_STRINGS)
raise ValueError(
"LibCST can only parse code using one of the following versions of "
+ "Python's grammar: 3.5, 3.6, 3.7, 3.8. More versions may be "
+ f"Python's grammar: {comma_versions}. More versions may be "
+ "supported by future releases."
)

Expand Down