fix(dependency): add back typing-extensions for 3.9#1358
Conversation
Missing typing-extensions breaks "from libcst.codemod import CodemodContext"
|
Hi @Lee-W! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
|
Hmm looks like this was broken in 1.8.0 (specifically in #1294), but why didn't the tests catch it? |
|
Ah I see, the test dependencies transitively include |
|
Thanks for the fix! |
|
I've put up #1359 to make sure this never happens again |
|
Thanks for helping us merge it! It seems we excluded 1.8.0 last time (I wasn't aware), and this time 1.8.1 breaks my PR, which is why I find it. Glad to know 1.8.2 would work fine! |
Missing typing-extensions breaks "from libcst.codemod import CodemodContext"
Summary
Missing typing-extensions breaks "from libcst.codemod import CodemodContext"
This can be verified by
uv run --python 3.9 --with libcst==1.8.1 python -c "from libcst.codemod import CodemodContext"it raises the following error
while it works fine for 3.10
uv run --python 3.10 --with libcst==1.8.1 python -c "from libcst.codemod import CodemodContext"Test Plan