[iOS11] Update project settings and fix errors #942
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rnystrom has updated the pull request. |
|
Failures fixed in #946 |
4 tasks
2 tasks
|
@rnystrom has updated the pull request. |
There was a problem hiding this comment.
@rnystrom is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
barakyoresh
pushed a commit
to Lightricks/IGListKit
that referenced
this pull request
Nov 1, 2017
Summary: Updated the main project lib settings for iOS 11, fixed all errors (which are from warnings-as-errors). - [x] All tests pass. Demo project builds and runs. - [x] I added an entry to the `CHANGELOG.md` for any breaking changes, enhancements, or bug fixes. Closes Instagram#942 Differential Revision: D6161473 Pulled By: rnystrom fbshipit-source-id: 1fd51d8805f9c6483942b44d750b2756efde9376
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes in this pull request
Updated the main project lib settings for iOS 11, fixed all errors (which are from warnings-as-errors).
Checklist
CHANGELOG.mdfor any breaking changes, enhancements, or bug fixes.