Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add -[IGListAdapter sectionControllerForSection:] #477

Closed
wants to merge 2 commits into from

Conversation

Adlai-Holler
Copy link
Contributor

Before the diff, you can lookup the object for a given section, and then lookup the section controller for that object, but this seems like a pretty valuable/common operation.

@Adlai-Holler
Copy link
Contributor Author

I put the changelog in the 2.2.0 release, I hope you guys will drop it in.

Copy link
Contributor

@jessesquires jessesquires left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! 🎉

Thanks @Adlai-Holler !

@jessesquires jessesquires added this to the 2.2.0 milestone Feb 8, 2017
Copy link
Contributor

@rnystrom rnystrom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Adlai-Holler can you add a test for this?

@facebook-github-bot
Copy link
Contributor

@Adlai-Holler updated the pull request - view changes

@facebook-github-bot
Copy link
Contributor

@rnystrom has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@jessesquires jessesquires modified the milestones: 2.2.0, 3.0.0 Feb 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants