-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add NSObject Conformance to IGListUpdatingDelegate #435
Add NSObject Conformance to IGListUpdatingDelegate #435
Conversation
9e835d8
to
73e596f
Compare
@Adlai-Holler updated the pull request - view changes |
@Adlai-Holler updated the pull request - view changes |
1 similar comment
@Adlai-Holler updated the pull request - view changes |
@jessesquires 2.2 or 3.0? |
@rnystrom 🤔 Hm... 2.2 for ObjC. Does this break anything in Swift? (I suspect yes, which case, 3.0) |
It would if you write your own Swift class MyCustomUpdater: IGListUpdatingDelegate { ... } But now it probably has to be class MyCustomUpdater: NSObject, IGListUpdatingDelegate { ... } I think. |
@Adlai-Holler updated the pull request - view changes |
@rnystrom right - let's double check |
@Adlai-Holler updated the pull request - view changes |
BTW fellas I did double-check, and it's true. |
@rnystrom has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
Pull request checklist
CHANGELOG.md
for any breaking changes, enhancements, or bug fixes.