Add NSObject Conformance to IGListUpdatingDelegate #435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adlai-Holler
changed the title
Adlai-Holler
force-pushed
the
UpdatingDelegateNSObject
branch
from
9e835d8
to
73e596f
Compare
|
@Adlai-Holler updated the pull request - view changes |
|
@Adlai-Holler updated the pull request - view changes |
1 similar comment
|
@Adlai-Holler updated the pull request - view changes |
|
@jessesquires 2.2 or 3.0? |
|
@rnystrom 🤔 Hm... 2.2 for ObjC. Does this break anything in Swift? (I suspect yes, which case, 3.0) |
|
It would if you write your own Swift class MyCustomUpdater: IGListUpdatingDelegate { ... }But now it probably has to be class MyCustomUpdater: NSObject, IGListUpdatingDelegate { ... }I think. |
|
@Adlai-Holler updated the pull request - view changes |
|
@rnystrom right - let's double check |
|
@Adlai-Holler updated the pull request - view changes |
|
BTW fellas I did double-check, and it's true. |
|
@rnystrom has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
CHANGELOG.mdfor any breaking changes, enhancements, or bug fixes.