Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for #378 - emptyView not updated when items added #395

Closed
wants to merge 4 commits into from
Closed

Fix for #378 - emptyView not updated when items added #395

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8037306
fix emptyview behavior and add unit tests
edmonston Jan 7, 2017
4edf558
updated CHANGELOG.md
Jan 8, 2017
260b790
Update CHANGELOG.md
edmonston Jan 8, 2017
0d535ae
Update CHANGELOG.md
edmonston Jan 8, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,11 +2,16 @@

The changelog for `IGListKit`. Also see the [releases](https://github.com/instagram/IGListKit/releases) on GitHub.

2.2.0
-----

This release closes the [2.2.0 milestone](https://github.com/Instagram/IGListKit/milestone/4)

### Enhancements
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just for the sake of completion we should add a header for 2.2.0 with a link to the milestone

Also can you add a link to this pull request at the end of your contribution, following the same format as other changelog entries

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure thing, CHANGELOG.md updated.


### Fixes

- Fix bug where emptyView's hidden status is not updated after the number of items is changed with `insertInSectionController:atIndexes:` or related methods [Peter Edmonston](https://github.com/edmonston)
- Fix bug where emptyView's hidden status is not updated after the number of items is changed with `insertInSectionController:atIndexes:` or related methods. [Peter Edmonston](https://github.com/edmonston) [(#395)](https://github.com/Instagram/IGListKit/pull/395)

2.1.0
-----
Expand Down