-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix stacked section controller OOB when cell ends display #358
Conversation
@@ -21,6 +21,8 @@ This release closes the [2.1.0 milestone](https://github.com/Instagram/IGListKit | |||
|
|||
- Prevent adapter data source from deallocating after queueing an update. [Ryan Nystrom](https://github.com/rnystrom) (tbd) | |||
|
|||
- Fix OOB bug when child section controllers in a stack remove cells. [Ryan Nystrom](https://github.com/rnystrom) [(#358)](https://github.com/Instagram/IGListKit/pull/358) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
spell out out-of-bounds 😄
@rnystrom updated the pull request - view changes |
@rnystrom - oh i forgot, we can edit files inline on the GH web UI. pretty sweet. fixed my own nits. 😄 we should probably do this with contributors from now on instead of commenting. |
@jessesquires has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
@jessesquires that is AWESOME. Hell yes. |
Changes in this pull request
Fixes bug reported internally. When items are removed dynamically the stack internal store will attempt to access data that has already been removed. Instead use assoc objects.
We did change
IGListAdapter
to use a map instead of assoc objects. That could be a good cleanup.cc @cdoncarroll
Pull request checklist