Fix broken links, fix travis #344
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Sherlouk - is there any way to have |
|
@jessesquires has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
|
@jessesquires I don't think we can do that as part of markdown-link-check, but the command we use simply iterates over all MD files and runs the link checker. We could probably have it print out the title of the page before it checks the page?
|
3 tasks
facebook-github-bot
pushed a commit
that referenced
this pull request
Dec 20, 2016
Summary: Wasn't sure how to make it a one line wonder, so probably could be improved -- but slapped it into a while loops and print name before triggering the `markdown-link-check`. Refers to #344 (comment) - [x] All tests pass. Demo project builds and runs. - [x] I added tests, an experiment, or detailed why my change isn't tested. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/.github/CONTRIBUTING.md) Closes #345 Differential Revision: D4352870 Pulled By: jessesquires fbshipit-source-id: df62c7c29c7236cba5a9163819c56247dd2d5070
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Caught by travis.
https://travis-ci.org/Instagram/IGListKit/jobs/185367790
Many thanks to @Sherlouk for setting this up. 💯