Prevent item reload, delete, insert collisions #325
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rnystrom updated the pull request - view changes |
| } else { | ||
| NSArray *indexPaths = [self indexPathsFromSectionController:sectionController indexes:indexes adjustForUpdateBlock:YES]; | ||
| [self.updatingDelegate reloadItemsInCollectionView:collectionView indexPaths:indexPaths]; | ||
| } |
jessesquires
approved these changes
Dec 13, 2016
|
Is there an open issue for this? |
|
update CHANGELOG 😄 |
|
@jessesquires not on GH but t14617176 tracking internally, commandeered D4237742. +1 changelog will update. |
1 similar comment
|
@rnystrom updated the pull request - view changes |
|
|
|
@rnystrom updated the pull request - view changes |
|
@rnystrom has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
|
Changes Unknown when pulling 0f3e79d on bad-update into ** on master**. |
2 similar comments
|
Changes Unknown when pulling 0f3e79d on bad-update into ** on master**. |
|
Changes Unknown when pulling 0f3e79d on bad-update into ** on master**. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes in this pull request
Adds a new test and fixes an item animation collision that
UICollectionViewthrows on. Basically we cannot collide reloads with insert+delete.The example in the test is trivial, but real-world situations do appear b/c of the coalescence of
IGListAdapterUpdater. It can queue reloads and deletes/inserts at the same index paths while waiting.Pull request checklist