-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prevent item reload, delete, insert collisions #325
Conversation
@rnystrom updated the pull request - view changes |
} else { | ||
NSArray *indexPaths = [self indexPathsFromSectionController:sectionController indexes:indexes adjustForUpdateBlock:YES]; | ||
[self.updatingDelegate reloadItemsInCollectionView:collectionView indexPaths:indexPaths]; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😱
Is there an open issue for this? |
update CHANGELOG 😄 |
@jessesquires not on GH but t14617176 tracking internally, commandeered D4237742. +1 changelog will update. |
1 similar comment
@rnystrom updated the pull request - view changes |
|
@rnystrom updated the pull request - view changes |
@rnystrom has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
Changes Unknown when pulling 0f3e79d on bad-update into ** on master**. |
2 similar comments
Changes Unknown when pulling 0f3e79d on bad-update into ** on master**. |
Changes Unknown when pulling 0f3e79d on bad-update into ** on master**. |
Changes in this pull request
Adds a new test and fixes an item animation collision that
UICollectionView
throws on. Basically we cannot collide reloads with insert+delete.The example in the test is trivial, but real-world situations do appear b/c of the coalescence of
IGListAdapterUpdater
. It can queue reloads and deletes/inserts at the same index paths while waiting.Pull request checklist