Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more unit tests to stack section controller #286

Closed
wants to merge 2 commits into from

Conversation

rnystrom
Copy link
Contributor

@rnystrom rnystrom commented Dec 5, 2016

Changes in this pull request

Beefing up our test coverage. Made an improvement to supplementary view behavior along the way. Will update CHANGELOG.md once travis finishes w/ link to PR #.

Pull request checklist

  • All tests pass. Demo project builds and runs.
  • I added tests, an experiment, or detailed why my change isn't tested.
  • I have reviewed the contributing guide

Copy link
Contributor

@jessesquires jessesquires left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice 💯

@facebook-github-bot
Copy link
Contributor

@rnystrom updated the pull request - view changes

@facebook-github-bot
Copy link
Contributor

@jessesquires has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@coveralls
Copy link

coveralls commented Dec 6, 2016

Coverage Status

Coverage increased (+2.7%) to 96.841% when pulling 6cccb90 on test-coverage into e1d6f52 on master.

@jessesquires jessesquires deleted the test-coverage branch December 6, 2016 02:23
@coveralls
Copy link

coveralls commented Dec 6, 2016

Coverage Status

Coverage increased (+2.9%) to 97.059% when pulling 6cccb90 on test-coverage into e1d6f52 on master.

@jessesquires jessesquires added this to the 2.0.0 milestone Dec 6, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants