Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unit tests for -scrollToObject horizontal end position #247

Closed
wants to merge 2 commits into from
Closed

Unit tests for -scrollToObject horizontal end position #247

wants to merge 2 commits into from

Conversation

zhubofei
Copy link

@zhubofei zhubofei commented Nov 22, 2016 •
edited
Loading

Fixes #238

Try to finish what I started 😂

@facebook-github-bot
Copy link
Contributor

@zhubofei updated the pull request - view changes

@jessesquires
Copy link
Contributor

🎉 👍

@jessesquires jessesquires added this to the 2.0.0 milestone Nov 22, 2016
@coveralls
Copy link

coveralls commented Nov 22, 2016 •
edited
Loading

Coverage Status

Coverage remained the same at 94.489% when pulling d61122c on zhubofei:scroll-test into 316fbe2 on Instagram:master.

@coveralls
Copy link

coveralls commented Nov 22, 2016 •
edited
Loading

Coverage Status

Coverage increased (+0.2%) to 94.674% when pulling d61122c on zhubofei:scroll-test into 316fbe2 on Instagram:master.

@facebook-github-bot
Copy link
Contributor

@rnystrom has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@zhubofei zhubofei deleted the scroll-test branch November 22, 2016 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
2.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@zhubofei @facebook-github-bot @jessesquires @coveralls