Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs updates and refinements, #181 #198

Closed
wants to merge 5 commits into from
Closed

Docs updates and refinements, #181 #198

wants to merge 5 commits into from

Conversation

jessesquires
Copy link
Contributor

@jessesquires jessesquires commented Nov 15, 2016 •
edited
Loading

Did a full pass on documentation.

  • Clean up
  • Fixes
  • Better markdown

NOTE: this PR does not re-gen docs. I will do that next. Before we cut 2.0

@jessesquires jessesquires added this to the 2.0.0 milestone Nov 15, 2016
@jessesquires
Copy link
Contributor Author

Example:

Before:

screen shot 2016-11-14 at 9 01 32 am

After:

screen shot 2016-11-14 at 9 02 23 am

@jessesquires
Copy link
Contributor Author

This also brings us from 79% docs coverage to 97%. 🎉

screen shot 2016-11-14 at 5 37 03 pm

@rnystrom
Copy link
Contributor

This also brings us from 79% docs coverage to 97%.

🔥 🔥 🔥

@facebook-github-bot
Copy link
Contributor

@jessesquires has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 91.441% when pulling 25b935c on docs-update into 0f2a715 on master.

@jessesquires jessesquires deleted the docs-update branch November 15, 2016 21:33
@jessesquires jessesquires mentioned this pull request Nov 15, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
2.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@jessesquires @rnystrom @facebook-github-bot @coveralls