Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IGListDiffKit should support APPLICATION_EXTENSION_API_ONLY #1422

Closed
wants to merge 1 commit into from
Closed

IGListDiffKit should support APPLICATION_EXTENSION_API_ONLY #1422

wants to merge 1 commit into from

Conversation

pm-dev
Copy link
Contributor

@pm-dev pm-dev commented Jan 23, 2020

Changes in this pull request

Issue fixed: #1421

This PR checks the box that indicates the framework is safe to be used in App Extensions
Screen Shot 2020-02-08 at 3 27 47 PM

Checklist

  • All tests pass. Demo project builds and runs.
  • I added tests, an experiment, or detailed why my change isn't tested.
  • I added an entry to the CHANGELOG.md for any breaking changes, enhancements, or bug fixes.
  • I have reviewed the contributing guide

@aaronbrethorst
Copy link

@pm-dev rebasing against master will get the CI tests passing again. The fix for failure you're seeing here was finally merged 12 hours ago: #1425

@pm-dev
Copy link
Contributor Author

pm-dev commented Feb 12, 2020

@aaronbrethorst looks like the Pod Lint step of CI is still failing.
bundle exec pod lib lint --allow-warnings "--include-podspecs=*.podspec"

Results in a failure:
- ERROR | [OSX] unknown: Encountered an unknown error (The platform of the target App(macOS 10.11) is not compatible withIGListSwiftKit (4.1.0), which does not support macOS.) during validation.

@koenpunt Looks like you added IGListSwiftKit. Do you mind taking a look?

@3a4oT
Copy link
Contributor

3a4oT commented Feb 13, 2020

Can we expect a minor release anytime soon?

@3a4oT
Copy link
Contributor

3a4oT commented Feb 18, 2020

ping @lorixx ;

@lorixx
Copy link
Contributor

lorixx commented Feb 26, 2020

Thanks @pm-dev and @3a4oT ! I have fixed the CI Travis build+lint errors, pls rebase and re-trigger the CI build, once it's green I am happy to merge, thanks!

@pm-dev
Copy link
Contributor Author

pm-dev commented Feb 26, 2020

Thanks @lorixx. Checks are passing

@lorixx
Copy link
Contributor

lorixx commented Feb 26, 2020

Awesome! Merging now

Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lorixx is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@lorixx merged this pull request in c321831.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IGListDiffKit should support APPLICATION_EXTENSION_API_ONLY
5 participants