Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cut 3.0.0 release #707

Closed
15 tasks done
rnystrom opened this issue May 1, 2017 · 6 comments
Closed
15 tasks done

Cut 3.0.0 release #707

rnystrom opened this issue May 1, 2017 · 6 comments
Milestone
3.0.0

Comments

@rnystrom
Copy link
Contributor

rnystrom commented May 1, 2017 •
edited by jessesquires
Loading

  • Final review and update of header docs and guides
  • Final review of changelog
  • Regenerate docs
  • Update pod spec version
  • Update xcodeproj version
  • Run pod install on all examples (must happen on FB internal because of sync issues)
  • Merge master into stable via cmd-line and push
  • Confirm stable is 0|0 ahead/behind
  • Create GitHub release from stable
  • Paste changelog into GH release notes
  • Publish GitHub release
  • Run pod lib lint
  • Push updated podspec: pod trunk push IGListKit.podspec
  • Verify new release on CocoaPods
  • Tweet all the tweets
@rnystrom rnystrom added this to the 3.0.0 milestone May 1, 2017
@rnystrom
Copy link
Contributor Author

rnystrom commented May 1, 2017 •
edited
Loading

Blocked on #593, #661, and #671

@amonshiz
Copy link
Contributor

amonshiz commented May 1, 2017

#671 is now closed

This was referenced May 10, 2017
Closed
Closed
Closed
Closed
facebook-github-bot pushed a commit that referenced this issue May 10, 2017
@facebook-github-bot
Fill in tbd in changelog
2363352 
Summary:
Part of #707

Closes #729

Reviewed By: rnystrom

Differential Revision: D5036882

Pulled By: jessesquires

fbshipit-source-id: 2fe99b66608fff52bb42cac46073b32d0865d007
facebook-github-bot pushed a commit that referenced this issue May 10, 2017
@facebook-github-bot
Bump pod and project version to 3.0.0
d1cd23b 
Summary:
Part of #707
Closes #731

Reviewed By: rnystrom

Differential Revision: D5036877

Pulled By: jessesquires

fbshipit-source-id: f63ce3369019870df87ebde59d6f6b0e95c8ad87
facebook-github-bot pushed a commit that referenced this issue May 10, 2017
@facebook-github-bot
Proof guides for consisntency and name changes
b6217a6 
Summary:
Part of #707
Closes #730

Differential Revision: D5039060

Pulled By: rnystrom

fbshipit-source-id: d54259b2dddbaba0fe2e69c6dd08a37fd17fbc4a
@Sherlouk
Copy link
Contributor

Not sure if this is covered by Final review and update of header docs and guides but we need to update all the version references to 3.0 (for example the installation guide and on the readme)

facebook-github-bot pushed a commit that referenced this issue May 10, 2017
@facebook-github-bot
Regen example project files
f743b1c 
Summary:
Regen example projects w/ pod script file.

Part of #707

Reviewed By: jessesquires

Differential Revision: D5039135

fbshipit-source-id: d29bcf635aea59aa589bd90644fb1ece6279cc10
@jessesquires
Copy link
Contributor

@Sherlouk yep! want to PR that?

@Sherlouk Sherlouk mentioned this issue May 11, 2017
Closed
facebook-github-bot pushed a commit that referenced this issue May 11, 2017
@Sherlouk @facebook-github-bot
Update version number in docs
a8190f3 
Summary:
Part of #707
Closes #734

Differential Revision: D5046692

Pulled By: jessesquires

fbshipit-source-id: db43f99fd0bbf4186a1bd47070f28a9a446bc2a4
@jessesquires
Copy link
Contributor

@rnystrom @amonshiz @Sherlouk

looks like 3.0 is ready! just need to re-gen docs (#728) and double check that everything is good to go.

all extra eyes will help! 👀

facebook-github-bot pushed a commit that referenced this issue May 12, 2017
@facebook-github-bot
Regen docs for 3.0
32a566d 
Summary:
~~Land after #661, #730 and D5031184~~

Rebuild the docs from script. Couple notes:

- Went from 100% to 99%, does that matter? Script output says
  - > 99% documentation coverage with 2 undocumented symbols
  - Looks like `NS_SWIFT_NAME` throws documentation for a loop on `IGListDiffOption` and `IGListExperiment`
- Swift names are different, will that be a problem?

Part of #707

Closes #728

Differential Revision: D5050951

Pulled By: jessesquires

fbshipit-source-id: 19249c1d34e6f253b911965114fd4ae7458d2684
@jessesquires
Copy link
Contributor

3.0 is released!

Iron-Ham pushed a commit to Iron-Ham/IGListKit that referenced this issue May 16, 2017
Implemented SwiftLint, new PR
e7f04cf 
Replaced force unwraps with explicit fatalErrors

Deleted file.zip

Updated UITestCase spacing

Updated variableName => identifierName

Fill in tbd in changelog

Summary:
Part of Instagram#707

Closes Instagram#729

Reviewed By: rnystrom

Differential Revision: D5036882

Pulled By: jessesquires

fbshipit-source-id: 2fe99b66608fff52bb42cac46073b32d0865d007

Bump pod and project version to 3.0.0

Summary:
Part of Instagram#707
Closes Instagram#731

Reviewed By: rnystrom

Differential Revision: D5036877

Pulled By: jessesquires

fbshipit-source-id: f63ce3369019870df87ebde59d6f6b0e95c8ad87

Proof guides for consisntency and name changes

Summary:
Part of Instagram#707
Closes Instagram#730

Differential Revision: D5039060

Pulled By: rnystrom

fbshipit-source-id: d54259b2dddbaba0fe2e69c6dd08a37fd17fbc4a

Regen example project files

Summary:
Regen example projects w/ pod script file.

Part of Instagram#707

Reviewed By: jessesquires

Differential Revision: D5039135

fbshipit-source-id: d29bcf635aea59aa589bd90644fb1ece6279cc10

Update version number in docs

Summary:
Part of Instagram#707
Closes Instagram#734

Differential Revision: D5046692

Pulled By: jessesquires

fbshipit-source-id: db43f99fd0bbf4186a1bd47070f28a9a446bc2a4

3.0 migration guide

Summary:
Will add to this as we close out the [milestone](https://github.com/Instagram/IGListKit/milestone/3).

Issue fixed: Instagram#475
Closes Instagram#661

Differential Revision: D5047071

Pulled By: jessesquires

fbshipit-source-id: 78989529f50c9b281960e5acf843e91198677432

Fix UICollectionView debug dump script

Summary:
Duh, need to import macro

Issue fixed: Instagram#722

- [x] All tests pass. Demo project builds and runs.
Closes Instagram#733

Differential Revision: D5040026

Pulled By: jessesquires

fbshipit-source-id: e9e51137ab4f7fa949667e3f3d644cd5c03abf80

Rename sectionIndex API to just section

Summary:
Quick rename before releasing 3.0 to get this API in parity w/ `isFirstSection` and `isLastSection`. My b I should have caught this in review.

Closes Instagram#720

Reviewed By: jessesquires, amonshiz

Differential Revision: D5031184

fbshipit-source-id: 1cd7b00c8b32084fecd861e78808eea0d0056337

Update CHANGELOG.md

Summary: Closes Instagram#735

Differential Revision: D5048185

Pulled By: jessesquires

fbshipit-source-id: 3f1a6826a4088043d883533f4f933a0a7ea42d60

Regen docs for 3.0

Summary:
~~Land after Instagram#661, Instagram#730 and D5031184~~

Rebuild the docs from script. Couple notes:

- Went from 100% to 99%, does that matter? Script output says
  - > 99% documentation coverage with 2 undocumented symbols
  - Looks like `NS_SWIFT_NAME` throws documentation for a loop on `IGListDiffOption` and `IGListExperiment`
- Swift names are different, will that be a problem?

Part of Instagram#707

Closes Instagram#728

Differential Revision: D5050951

Pulled By: jessesquires

fbshipit-source-id: 19249c1d34e6f253b911965114fd4ae7458d2684

Fixup project, update README and guides

Summary:
- Fix OCMock issues with tvOS tests
- Update README/guides
Closes Instagram#737

Differential Revision: D5052333

Pulled By: jessesquires

fbshipit-source-id: 958444d892c14dd4c75e244f20ae21bbfeec8290

final docs update for 3.0

Summary: Closes Instagram#738

Differential Revision: D5052802

Pulled By: jessesquires

fbshipit-source-id: b1ace763da9edbb7bc65ecb9af34aa791e617aa7
Iron-Ham pushed a commit to Iron-Ham/IGListKit that referenced this issue May 16, 2017
Implemented SwiftLint, new PR
a083d7a 
Replaced force unwraps with explicit fatalErrors

Deleted file.zip

Updated UITestCase spacing

Updated variableName => identifierName

Fill in tbd in changelog

Summary:
Part of Instagram#707

Closes Instagram#729

Reviewed By: rnystrom

Differential Revision: D5036882

Pulled By: jessesquires

fbshipit-source-id: 2fe99b66608fff52bb42cac46073b32d0865d007

Bump pod and project version to 3.0.0

Summary:
Part of Instagram#707
Closes Instagram#731

Reviewed By: rnystrom

Differential Revision: D5036877

Pulled By: jessesquires

fbshipit-source-id: f63ce3369019870df87ebde59d6f6b0e95c8ad87

Proof guides for consisntency and name changes

Summary:
Part of Instagram#707
Closes Instagram#730

Differential Revision: D5039060

Pulled By: rnystrom

fbshipit-source-id: d54259b2dddbaba0fe2e69c6dd08a37fd17fbc4a

Regen example project files

Summary:
Regen example projects w/ pod script file.

Part of Instagram#707

Reviewed By: jessesquires

Differential Revision: D5039135

fbshipit-source-id: d29bcf635aea59aa589bd90644fb1ece6279cc10

Update version number in docs

Summary:
Part of Instagram#707
Closes Instagram#734

Differential Revision: D5046692

Pulled By: jessesquires

fbshipit-source-id: db43f99fd0bbf4186a1bd47070f28a9a446bc2a4

3.0 migration guide

Summary:
Will add to this as we close out the [milestone](https://github.com/Instagram/IGListKit/milestone/3).

Issue fixed: Instagram#475
Closes Instagram#661

Differential Revision: D5047071

Pulled By: jessesquires

fbshipit-source-id: 78989529f50c9b281960e5acf843e91198677432

Fix UICollectionView debug dump script

Summary:
Duh, need to import macro

Issue fixed: Instagram#722

- [x] All tests pass. Demo project builds and runs.
Closes Instagram#733

Differential Revision: D5040026

Pulled By: jessesquires

fbshipit-source-id: e9e51137ab4f7fa949667e3f3d644cd5c03abf80

Rename sectionIndex API to just section

Summary:
Quick rename before releasing 3.0 to get this API in parity w/ `isFirstSection` and `isLastSection`. My b I should have caught this in review.

Closes Instagram#720

Reviewed By: jessesquires, amonshiz

Differential Revision: D5031184

fbshipit-source-id: 1cd7b00c8b32084fecd861e78808eea0d0056337

Update CHANGELOG.md

Summary: Closes Instagram#735

Differential Revision: D5048185

Pulled By: jessesquires

fbshipit-source-id: 3f1a6826a4088043d883533f4f933a0a7ea42d60

Regen docs for 3.0

Summary:
~~Land after Instagram#661, Instagram#730 and D5031184~~

Rebuild the docs from script. Couple notes:

- Went from 100% to 99%, does that matter? Script output says
  - > 99% documentation coverage with 2 undocumented symbols
  - Looks like `NS_SWIFT_NAME` throws documentation for a loop on `IGListDiffOption` and `IGListExperiment`
- Swift names are different, will that be a problem?

Part of Instagram#707

Closes Instagram#728

Differential Revision: D5050951

Pulled By: jessesquires

fbshipit-source-id: 19249c1d34e6f253b911965114fd4ae7458d2684

Fixup project, update README and guides

Summary:
- Fix OCMock issues with tvOS tests
- Update README/guides
Closes Instagram#737

Differential Revision: D5052333

Pulled By: jessesquires

fbshipit-source-id: 958444d892c14dd4c75e244f20ae21bbfeec8290

final docs update for 3.0

Summary: Closes Instagram#738

Differential Revision: D5052802

Pulled By: jessesquires

fbshipit-source-id: b1ace763da9edbb7bc65ecb9af34aa791e617aa7

Deleted SwiftLint directory
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.0.0
Development

No branches or pull requests
4 participants
@rnystrom @amonshiz @jessesquires @Sherlouk