Skip to content

Commit

Permalink
Call copy method to avoid a potential issue for an NSString property
Browse files Browse the repository at this point in the history
Summary:
According to rnystrom 's comment on #125 , we leave only two small changes in this PR.
1. Call copy method to avoid a potential issue for an `NSString` property.
2. fix a typo.

close #125

- [x] All tests pass. Demo project builds and runs.
- [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/CONTRIBUTING.md)
Closes #131

Differential Revision: D4095492

Pulled By: rnystrom

fbshipit-source-id: b162842a38850c826685efd0746022daabe9d2b8
  • Loading branch information
JakeLin authored and Facebook Github Bot committed Oct 28, 2016
1 parent a3d5c14 commit eca0205
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion Source/IGListDiffable.h
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@

/**
The IGListDiffable protocol provides the base methods needed to compare the identity and equality of two objects using
one of the IGKAlgorithm functions.
one of the IGListDiff functions.
*/
@protocol IGListDiffable

Expand Down
2 changes: 1 addition & 1 deletion Source/IGListSingleSectionController.m
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ - (instancetype)initWithNibName:(NSString *)nibName
IGParameterAssert(configureBlock != nil);
IGParameterAssert(sizeBlock != nil);
if (self = [super init]) {
_nibName = nibName;
_nibName = [nibName copy];
_bundle = bundle;
_configureBlock = [configureBlock copy];
_sizeBlock = [sizeBlock copy];
Expand Down

0 comments on commit eca0205

Please sign in to comment.