Update readme with new manual download URL #497
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AhmedOS
reviewed
Jul 1, 2024
README.md
Outdated
Comment on lines
55
to
60
| 4. Create a new "Run Script Phase" in your project’s target "Build Phases" and add the following snippet | ||
|
|
||
| ``` | ||
| bash "${BUILT_PRODUCTS_DIR}/${FRAMEWORKS_FOLDER_PATH}/Instabug.framework/strip-frameworks.sh" | ||
| ``` | ||
| 4. In Xcode 11.x you might get the following error: | ||
| 5. In Xcode 11.x you might get the following error: |
There was a problem hiding this comment.
Steps 4 and 5 are outdated, can we please remove them?
README.md
Outdated
|
|
||
| 3. Create a new "Run Script Phase" in your project’s target "Build Phases" and add the following snippet | ||
| 3. Extract it then drag & drop Instabug.xcframework to your project's "Frameworks, Libraries, and Embedded Content" section under the "General" tab, and make sure that the "Copy items if needed" checkbox is checked |
There was a problem hiding this comment.
This needs to be updated to Xcode 15 UI (Embed: Embed Without Signing).
AhmedOS
approved these changes
Jul 1, 2024
mzelzoghbi
approved these changes
Jul 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
Update the old manual download URL with a new URL that will navigate to the SDK's latest releases on GitHub
Checklists
Code review