Skip to content

[MOB-12070] Disable Sorucemaps Scripts on CI #940

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 12, 2023
Merged

[MOB-12070] Disable Sorucemaps Scripts on CI #940

merged 2 commits into from
Mar 12, 2023

Conversation

TheBuggedYRN
Copy link
Contributor

@TheBuggedYRN TheBuggedYRN commented Mar 9, 2023 •
edited
Loading

Description of the change

The upload scripts used to run while running both Unit and E2E CI jobs, resulting in more redundant time or unintended behavior. These scripts were disabled by:

  1. Android: passing the instabugUploadEnable gradle property.
  2. iOS: setting the INSTABUG_SOURCEMAPS_UPLOAD_DISABLE environment variable.

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

Issue links go here

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests

Code review

  • This pull request has a descriptive title and information useful to a reviewer
  • Issue from task tracker has a link to this pull request

@TheBuggedYRN TheBuggedYRN self-assigned this Mar 9, 2023
@TheBuggedYRN TheBuggedYRN changed the title Disable Sorucemaps Upload Scripts on CI [MOB-12070] Disable Sorucemaps Upload Scripts on CI Mar 12, 2023
@TheBuggedYRN TheBuggedYRN changed the title [MOB-12070] Disable Sorucemaps Upload Scripts on CI [MOB-12070] Disable Sorucemaps Scripts on CI Mar 12, 2023
@TheBuggedYRN TheBuggedYRN merged commit 06d364c into dev Mar 12, 2023
@TheBuggedYRN TheBuggedYRN deleted the ci/disable-upload-scripts branch March 12, 2023 08:43
HeshamMegid pushed a commit that referenced this pull request Apr 20, 2023
@TheBuggedYRN @HeshamMegid
[MOB-12070] Disable Sorucemaps Scripts on CI (#940)
ea6c292 
The upload scripts used to run while running both Unit and E2E CI jobs,
resulting in more redundant time or unintended behavior.

These scripts were disabled by:
 1. Android: passing the `instabugUploadEnable` gradle property.
 2. iOS: setting the `INSTABUG_SOURCEMAPS_UPLOAD_DISABLE` environment variable.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DavidMina96 DavidMina96 DavidMina96 approved these changes

@a7medev a7medev Awaiting requested review from a7medev

Assignees

@TheBuggedYRN TheBuggedYRN

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TheBuggedYRN @DavidMina96