Skip to content

[MOB-11974] Add Interfaces for Native Modules #918

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 16 commits into from
Feb 26, 2023
Merged

[MOB-11974] Add Interfaces for Native Modules #918

merged 16 commits into from
Feb 26, 2023

Conversation

TheBuggedYRN
Copy link
Contributor

@TheBuggedYRN TheBuggedYRN commented Feb 16, 2023 •
edited
Loading

Description of the change

Increase type-safety by adding type definitions for the Native Modules.

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

Issue links go here

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests

Code review

  • This pull request has a descriptive title and information useful to a reviewer
  • Issue from task tracker has a link to this pull request

@TheBuggedYRN TheBuggedYRN self-assigned this Feb 16, 2023
Base automatically changed from dev to master February 20, 2023 14:53
@TheBuggedYRN TheBuggedYRN changed the base branch from master to dev February 21, 2023 10:19
@TheBuggedYRN TheBuggedYRN marked this pull request as ready for review February 22, 2023 07:33
@TheBuggedYRN TheBuggedYRN changed the title Add Interfaces for Native Modules [MOB-11974] Add Interfaces for Native Modules Feb 22, 2023
a7medev
a7medev requested changes Feb 23, 2023
View reviewed changes
Copy link
Contributor

@a7medev a7medev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a huge step towards better DX and more type-safety and is definitely something that will make the New Architecture migration a breeze 👏❤️

@TheBuggedYRN TheBuggedYRN requested a review from a7medev February 26, 2023 10:40
@TheBuggedYRN TheBuggedYRN merged commit 1444353 into dev Feb 26, 2023
@TheBuggedYRN TheBuggedYRN deleted the refactor/native-types branch February 26, 2023 14:05
HeshamMegid pushed a commit that referenced this pull request Mar 1, 2023
@TheBuggedYRN @HeshamMegid
[MOB-11974] Add Interfaces for Native Modules (#918)
2130e1b 
Increase type-safety by adding type definitions for the Native Modules.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@a7medev a7medev a7medev approved these changes

@DavidMina96 DavidMina96 Awaiting requested review from DavidMina96

Assignees

@TheBuggedYRN TheBuggedYRN

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TheBuggedYRN @a7medev