Skip to content

feat: support app flows APIs #446

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Apr 23, 2024
Merged

feat: support app flows APIs #446

merged 9 commits into from
Apr 23, 2024

Conversation

abdelhamid-f-nasser
Copy link
Contributor

@abdelhamid-f-nasser abdelhamid-f-nasser commented Feb 21, 2024 •
edited
Loading

Description of the change

  • Support thew App Flows feature and it's below APIs:
    • APM.startFlow
    • APM.endFlow
    • APM.setTraceAttribute
  • Deprecate the following execution traces APIs in favor of the new app flow APIs:
    • APM.startExecutionTrace
    • APM.setExecutionTraceAttribute
    • APM.endExecutionTrace
    • Trace.setAttribute
    • Trace.end

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

Jira ID: APM-19518

Checklists

  • ⚠️ Replace the <next_release_deprecation_version> placeholder with the version of the SDK in the below files:
    • APM.dart
      • startExecutionTrace
      • setExecutionTraceAttribute
      • endExecutionTrace
    • Trace.dart
      • setAttribute
      • end

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests

Code review

  • This pull request has a descriptive title and information useful to a reviewer
  • Issue from task tracker has a link to this pull request

@abdelhamid-f-nasser abdelhamid-f-nasser changed the title chore: deprecate execution traces APIs feat: supoprt app flows APIs Feb 21, 2024
@abdelhamid-f-nasser abdelhamid-f-nasser self-assigned this Feb 21, 2024
@abdelhamid-f-nasser abdelhamid-f-nasser added pending-android Waiting for Android release pending-ios Waiting for iOS release labels Feb 21, 2024
@a7medev a7medev changed the title feat: supoprt app flows APIs feat: support app flows APIs Feb 21, 2024
@abdelhamid-f-nasser abdelhamid-f-nasser requested review from a team and removed request for a7medev and ahmedAlaaInstabug February 28, 2024 12:34
@mrashed98 mrashed98 added the READY FOR MERGE Reviewed and ready for merge (after release request) label Apr 15, 2024
@mrashed98 mrashed98 added this to the 24Q1C2 milestone Apr 16, 2024
a7medev
a7medev requested changes Apr 17, 2024
View reviewed changes
@abdelhamid-f-nasser @a7medev
Update CHANGELOG.md
1e6c5e5 
Co-authored-by: Ahmed Mahmoud <68241710+a7medev@users.noreply.github.com>
a7medev
a7medev requested changes Apr 22, 2024
View reviewed changes
@abdelhamid-f-nasser @a7medev
Update lib/src/modules/apm.dart
5938b43 
Co-authored-by: Ahmed Mahmoud <68241710+a7medev@users.noreply.github.com>
a7medev
a7medev approved these changes Apr 23, 2024
View reviewed changes
Copy link
Contributor

@a7medev a7medev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's go! 🚀

@ahmedAlaaInstabug ahmedAlaaInstabug merged commit c1f7851 into dev Apr 23, 2024
@ahmedAlaaInstabug ahmedAlaaInstabug deleted the feat/support-app-flows branch April 23, 2024 18:26
@a7medev a7medev mentioned this pull request Jul 31, 2024
Closed
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@a7medev a7medev a7medev approved these changes

Assignees

@abdelhamid-f-nasser abdelhamid-f-nasser

Labels
pending-android Waiting for Android release pending-ios Waiting for iOS release READY FOR MERGE Reviewed and ready for merge (after release request)
Projects
None yet
Milestone
24Q1C2
Development

Successfully merging this pull request may close these issues.
4 participants
@abdelhamid-f-nasser @a7medev @mrashed98 @ahmedAlaaInstabug