Skip to content

[MOB-12132] Release v2.2.0 #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 14, 2023
Merged

[MOB-12132] Release v2.2.0 #23

merged 2 commits into from
Mar 14, 2023

Conversation

DavidMina96
Copy link
Contributor

Description of the change

Description goes here

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

Issue links go here

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests

Code review

  • This pull request has a descriptive title and information useful to a reviewer
  • Issue from task tracker has a link to this pull request

@DavidMina96 DavidMina96 self-assigned this Mar 14, 2023
@@ -2,7 +2,7 @@ name: instabug_dio_interceptor
description:
This package is an add on to instabug_flutter. It intercepts any requests performed
with Dio Package and sends them to the report that will be sent to the dashboard.
version: 2.1.1
version: 2.2.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

question: Should we go for a major version? Since we are supporting new major version of dio, it will be easier to grasp the v3 work with dio v5, v2 works with dio v4.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have a point here, but since this change introduces no breaking changes, I prefer a minor version bump in this case.

@HeshamMegid HeshamMegid merged commit 4b8ee35 into master Mar 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants