Skip to content

Conversation

@DavidMina96
Copy link
Contributor

Description of the change

Description goes here

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

Issue links go here

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests

Code review

  • This pull request has a descriptive title and information useful to a reviewer
  • Issue from task tracker has a link to this pull request

@DavidMina96 DavidMina96 self-assigned this Feb 2, 2023
Copy link

@a7medev a7medev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was removing the package-lock.json in the example app intentional?

@DavidMina96
Copy link
Contributor Author

DavidMina96 commented Feb 2, 2023

@a7medev I think we all use yarn not npm. Do you prefer to have a yarn.lock checked-in?

@a7medev
Copy link

a7medev commented Feb 2, 2023

@DavidMina96 I think it's reasonable to do that but do you think it should be done in this PR?

@DavidMina96
Copy link
Contributor Author

@a7medev Let's do it since we'll squash and merge at the end.

@DavidMina96 DavidMina96 requested a review from a7medev February 2, 2023 12:50
@a7medev
Copy link

a7medev commented Feb 2, 2023

@DavidMina96 Alright, let's go with that.

@DavidMina96 DavidMina96 merged commit 452aa38 into dev Feb 2, 2023
@DavidMina96 DavidMina96 deleted the release/11.7.0 branch February 2, 2023 13:08
HeshamMegid pushed a commit that referenced this pull request Feb 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants